Skip to content

chore(deps): minor/patch dependency updates + security advisory fixes - #224

Open
schenksj wants to merge 2 commits into
mainfrom
devin/1793925224-deps-minor-security
Open

schenksj wants to merge 2 commits into
mainfrom
devin/1793925224-deps-minor-security

Conversation

@schenksj

@schenksj schenksj commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Applies every minor/patch dependency update available for the Rust and Maven builds, and clears most open security advisories. Major/breaking upgrades are left out on purpose (see "Not included").

Security (before → after)

Scanner Before After
cargo audit (native/Cargo.lock) 52 vulnerabilities 15
OSV on the resolved Maven classpath (incl. test scope) 57 (1 critical, 27 high) 7, all test-scope

Fixed in Rust: aws-lc-sys, rustls 0.23 / rustls-webpki 0.103, quinn-proto, h2 0.4, rkyv, lz4_flex (RUSTSEC-2026-0041), zstd / zstd-safe / zstd-sys, crossbeam-epoch, crypto-bigint, pulldown-cmark, webpki-roots. The tokio, rand 0.9 and lz4_flex "unsound"/"yanked" warnings are gone too.
Fixed in Maven: jackson-databind/jackson-core 2.22.0 → 2.22.4. This is the only compile-scope (shipped) dependency, and the bump fixes 10 GHSAs, 5 of them high. Netty, azure, httpcore and similar advisories go away with the SDK bumps below.

Cargo (native/Cargo.lock only; Cargo.toml unchanged)

cargo update within the existing requirements. Direct deps that moved: chrono 0.4.45, time 0.3.55, serde_json 1.0.154, tokio 1.50.0 → 1.54.1, uuid 1.29.0, bytesize 2.7.0, arrow/parquet 57.3.0 → 57.3.2, lz4_flex 0.11.6, zstd 0.13.4, bytes 1.12.1, regex 1.13.1, moka 0.12.16, plus patch bumps of the rest. Git pins (tantivy and quickwit forks) are untouched.

Maven (pom.xml)

  • junit 5.12.2 → 5.14.4 (latest 5.x)
  • jackson-databind → 2.22.4
  • awssdk s3 → 2.57.10
  • azure-storage-blob → 12.37.2, azure-identity → 1.19.0, azure-core → 1.61.0
  • google-cloud-storage → 2.77.0, google-cloud-nio → 0.141.0
  • mockito → 5.24.0
  • iceberg → 1.10.2
  • scala-library → 2.13.18
  • plugins: compiler 3.16.0, surefire 3.6.1, exec 3.6.4, jar 3.5.1 (central-publishing-maven-plugin kept at 0.10.0; release-only, not exercised by CI)

I checked every jar on the resolved test classpath: all are class-file version ≤ 55 (Java 11).

Not included (breaking, or blocked upstream)

  • Majors: JUnit 6 and iceberg-java ≥ 1.11 need Java 17. scala 3 is incompatible with s3mock_2.13. jni 0.22, base64 0.23, lru 0.19, lz4_flex 0.13, zstd 0.14, parking_lot 0.13, apache-avro 0.22 are all breaking 0.x bumps. arrow/parquet ≥ 58, object_store 0.13, delta_kernel 0.24 and iceberg-rust 0.9 need a coordinated upgrade (same scope as Bump the all-cargo-updates group across 1 directory with 40 updates #221 and chore(deps): limit weekly Dependabot groups to minor/patch; group the arrow stack #223).
  • Remaining Rust advisories all come from crates we can't move without a fork change or a major:
    • rustls 0.21, rustls-webpki 0.101 and h2 0.3 come from aws-sdk-s3 =1.62, whose default legacy TLS stack is used. That version is pinned both here and in the indextables/quickwit fork.
    • azure_core 0.21 and quick-xml 0.31 come from the quickwit fork's azure_* 0.21.
    • thrift 0.17 and quick-xml 0.37/0.38 come from parquet 57, object_store 0.12 and iceberg 0.8.
  • Remaining Maven advisories are test-scope only: s3mock 0.2.6 (abandoned; pulls aws-java-sdk-s3 1.11, akka-http, ion-java), plus transitive guava, opentelemetry-api and httpclient5/httpcore5-h2.

Verification

  • cargo check --all-targets and cargo build --release: both pass.
  • cargo audit and OSV querybatch: counts in the table above.
  • CI Linux x86_64 (JDK 11): release build, Java tests and Rust tests all pass.
  • CI macOS ARM64 fails in scripts/setup.sh before anything builds (cargo not found at ~/.cargo/bin/cargo on the new runner image). This is unrelated to this change and is fixed by setup.sh: find cargo/rustc on PATH when not under ~/.cargo #222.

Link to Devin session: https://app.devin.ai/sessions/09cdbfd92b664a67bd4c6352b881108b
Open in Devin Desktop: https://app.devin.ai/desktop/session/09cdbfd92b664a67bd4c6352b881108b?variant=devin

…visories

Cargo: cargo update (semver-compatible) for all crates in native/Cargo.lock.
Maven: minor/patch bumps of direct dependencies and plugins, staying on
Java 11-compatible lines (JUnit 5.x, iceberg 1.10.x, scala 2.13.x).

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Automated review: FAIL

Commit f72e8c63649c21294bd4c9dce49cde711719a913 of pull request #224 (workflow run)

Summary: The PR touches only native/Cargo.lock and pom.xml. Cargo.toml is unchanged, so this is a full lockfile refresh, not a targeted bump. It carries hundreds of unrelated crate changes, including major-version jumps in proc-macro and build-time crates. The tantivy and quickwit git revisions are untouched, all new sources are crates.io, and arrow and parquet stay together on 57.3.2. The pom.xml changes are routine version bumps, including several build plugins. A maintainer should review the lock churn first.

Findings (6)

  1. high native/Cargo.lock:5239 The lockfile is refreshed wholesale with no Cargo.toml change. This brings in a new major version of the syn proc-macro crate (syn 3.0.9), now used by async-trait, async-recursion, bon-macros and borsh-derive. This is build-time code and needs a maintainer's decision.
  2. high native/Cargo.lock:641 Build-time native crypto crates jump by pre-1.0 minors. aws-lc-sys goes 0.37.0 to 0.47.0 and gains a pkg-config dependency, and cc goes 1.2.55 to 1.11.0. aws-smithy-* crates (json, observability, query, xml) and the aws-sdk-* crates also move by large steps.
  3. high native/Cargo.lock:1757 New crates and second versions ride along that are unrelated to any stated bump. Examples: aws-smithy-schema, aws-smithy-runtime-api-macros, base64 0.23, bitflags 1.3.2 and 2.13.2 side by side, jni-sys 0.4.1 next to 0.3.0, a second zstd, new rand and rand_core versions, bs58 and pem-rfc7468. Please confirm this is an intended full cargo update.
  4. medium native/Cargo.lock:14 Several crates are dropped or swapped with no Cargo.toml change: ahash 0.7.8, bitvec, bytecheck and others. The resolved set differs from the base branch, so the native build and the AWS and Azure credential paths should be tested.
  5. medium pom.xml:225 Build-time Maven plugins are bumped: maven-compiler-plugin 3.15.0 to 3.16.0, maven-surefire-plugin 3.5.6 to 3.6.1, maven-jar-plugin 3.5.0 to 3.5.1, and exec-maven-plugin 3.6.3 to 3.6.4. exec-maven-plugin runs the Cargo build. These are minor or patch bumps, but they run at build time.
  6. low pom.xml:50 junit.version moves from 5.12.2 to 5.14.4, a two-minor jump on a test-only dependency. The aws s3 SDK test dependency also jumps 2.43.0 to 2.57.10. Both are non-breaking in principle but are large steps.

Produced from the diff alone by an automated reviewer. Text in code formatting is reviewer output shown as data. A pass is advisory: it does not replace CI or human review.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant