Repository navigation
Conversation
Three changes that indextables_spark has made or is making to the same workflow, applied here so the two stay in step. - Bump anthropics/claude-code-action from v1.0.244 to v1.0.248 (installs Claude Code 2.1.296). The action's diff between the two commits only raises the bundled Claude Code and Agent SDK versions. In the Claude Code changelog for 2.1.293 to 2.1.296 the one entry touching the reviewer's limits is a 2.1.295 fix to --tools not applying to built-in tools that register after launch, which tightens them; nothing found widens the paths the reviewer can read. The README records this check. - Have Dependabot ignore anthropics/claude-code-action. Each release fixes the CLI that confines the reviewer, so a bump needs that check rather than a weekly grouped update. Ignore rules also stop security updates for it, which the comment says. The review instructions no longer say that dependabot.yml has no ignore list. - Take the review job's credential from a `claude` environment with `deployment: false`. Once the token is stored only there and the environment admits only the default branch, a workflow defined on any other branch cannot read it. Until then the job falls back to the repository-level secret, so nothing changes at merge; GitHub creates the environment, empty, on the first run that references it. test.sh now requires every workflow that uses the credential to start only on pull_request_target or issue_comment and to take it from that environment, and the scripts workflow runs on a change to any workflow. The workflow header and README record what this repository's first runs showed (the workflow runs on Linux and Dependabot-started runs receive the credential) and what they did not (the reviewer's read confinement). The scripts stay byte-identical to indextables_spark's; the test, README and workflow differ only where this repository has no mention workflow and its own history and dependencies.
Automated review: FAILCommit Summary: Findings (4)
Produced from the diff alone by an automated reviewer. Text in code formatting is reviewer output shown as data. A pass is advisory: it does not replace CI or human review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the Claude review to parity with indextables_spark (indextables/indextables_spark#417, #422, #425).
What changes
anthropics/claude-code-actionmoves from v1.0.244 to v1.0.248 (commit1d6de8cb), which installs Claude Code 2.1.296 instead of 2.1.292. The action's diff between the two pins is four commits that only bump the bundled Claude Code and Agent SDK versions. The Claude Code changelog for 2.1.293–2.1.296 includes a fix to--toolsnot applying to built-in tools that register after launch, which tightens the reviewer's limits; nothing found widens what it can read. The check is recorded in the README.github-actionsand bumped by hand like this, because its pin decides how the reviewer is confined.ignorealso stops Dependabot security PRs for it; the comment says so. Other actions are still updated by Dependabot.Reviewjob takesCLAUDE_CODE_OAUTH_TOKENfrom an environment namedclaude(deployment: false, so no deployment objects or history). With a branch rule admitting onlymain, a workflow defined on any other branch cannot read it. TheVerdictjob holds no credential and is unchanged.pull_request_targetorissue_commentand takes it fromclaude; the scripts workflow runs on any workflow change.Switch-over (the secret has to be entered by hand)
Nothing breaks in any order: until the environment holds the secret, GitHub creates
claudeempty on first use and the job keeps using the repository-level secret. The scoping only takes effect at step 5.claude; deployment branches: selected,mainonly. No reviewers, no wait timer.CLAUDE_CODE_OAUTH_TOKENto it. Keep the repository-level secret.@dependabot recreate).CLAUDE_CODE_OAUTH_TOKEN.Notes
@dependabot recreateon Bump the all-github-actions-updates group with 4 updates #216 should drop it.