Repository navigation
ci: run the Claude review from main, on Dependabot PRs too, with a pass/fail verdict - #215
Merged
Merged
Conversation
…om-main workflow The review in claude-code-review.yml ran on `pull_request` with claude-code-action@beta, a `direct_prompt` and a pinned model, and currently fails on every pull request. It also had two structural problems: a `pull_request` workflow is defined by the pull request itself, so a change could rewrite the reviewer's prompt and tools while still receiving the credential; and runs started by Dependabot on `pull_request` receive no repository secrets, so dependency updates were never reviewed. Port the workflow already in use in indextables_spark: - claude-review.yml runs on `pull_request_target`, so the workflow and its scripts always come from the default branch. The pull request is never checked out; its diff is fetched through the API. The job starts only for same-repository, non-draft pull requests against the default branch by an allowlisted author. - The reviewer has Read/Grep/Glob only, confined to the base checkout and the diff file, with a read-only token. A second job without the credential validates the schema-constrained result, posts or updates one comment and is green only for `pass`; anything else, including a failed or timed-out review, is red. - Actions are pinned to commit ids and the runner to ubuntu-24.04. - .github/scripts/claude-review/ and claude-review-scripts.yml carry the scripts and their offline tests. The scripts are byte-identical to the sibling repository's. Adapted for this repository: - Review instructions keep the previous prompt's points (correctness, security, merge-conflict markers and build breaks, error propagation at the JNI boundary, API consistency; no style, no pre-existing issues) and add native resource and memory safety across JNI. - Dependency-update guidance covers the three ecosystems here (Maven, Cargo under native/, GitHub Actions): the tantivy and quickwit git revisions and exact-version requirements that are moved by hand, crate families that must move together, Cargo.lock sources and checksums, and build-time code (Maven plugins, build-dependencies, procedural macros, build.rs). - The header and one test no longer refer to a second workflow that does not exist here; the README quotes this repository's diff-size history. Behaviour changes to be aware of: the old workflow also started Claude on comments that mention it; this one does not. The check `claude-review` is replaced by `Review` and `Verdict`. Not verifiable before merge: a pull_request_target workflow only takes effect once it is on the default branch.
rbrenton
had a problem deploying
to
test-runners
October 8, 2026 19:36 — with
GitHub Actions
Failure
rbrenton
had a problem deploying
to
test-runners
October 8, 2026 19:36 — with
GitHub Actions
Failure
schenksj
enabled auto-merge (squash)
October 14, 2026 00:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the review workflow that is live in indextables_spark (indextables/indextables_spark#415). Supersedes #212.
Why
claude-code-review.ymlfails on every pull request (claude-reviewis red across the repo).pull_request, so the reviewer's prompt and tools come from the pull request under review, and runs that Dependabot triggers receive no Actions secrets, so it cannot review dependency updates.What changes
pull_request_target, which always takes the workflow and its checkout from the default branch.dependabot[bot],rbrenton,schenksjorchrisfauerbach. Fork pull requests and other authors skip the job.pass, red onfail, and red with a "did not complete" reason for anything else.native/and GitHub Actions: the tantivy and quickwit git revisions and the exactaws-sdk-s3requirement are held by hand, 0.x minor bumps count as major, arrow/parquet and iceberg crates move together, and build-time code (Maven plugins,build.rs, procedural macros) is flagged..github/scripts/claude-review/are byte-identical to indextables_spark's, with the same offline test suite.Behaviour change
claude-reviewcheck is replaced byReviewandVerdict(plusOffline testswhen the scripts or workflows change). None is a required check.@claude. That is not carried over (3 successful runs in its last 300). It can be restored as a separate workflow if wanted.Verification
arrow-buffer57→59 bump on its own was failed (family split, probable compile break), and ajackson-databindpatch bump and abyteslock-only bump passed.Not verifiable before merge
A
pull_request_targetworkflow only takes effect once on the default branch. After merge: close and reopen a same-repo PR for the human path, and@dependabot rebaseon one Dependabot PR for the bot path.The reviewer's read confinement has been probed locally on macOS only and has not been exercised on a Linux runner.