Skip to content

ci: move Claude review to claude-code-action@v1 and drop the model pin - #212

Closed
rbrenton wants to merge 1 commit into
mainfrom
feature/claude-review-unpin-model
Closed

rbrenton wants to merge 1 commit into
mainfrom
feature/claude-review-unpin-model

Conversation

@rbrenton

@rbrenton rbrenton commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Problem

The claude-review check fails on every pull request. The workflow pins model: "claude-sonnet-4-20250514", which has been retired, so the API returns 404 not_found_error and the action exits after one turn, leaving a "Claude encountered an error" comment on the PR. It has been red on every PR since at least 2026-09-28.

The workflow also uses the frozen anthropics/claude-code-action@beta tag, so removing the model line alone would not be a durable fix.

Change

Only the "Run Claude Code Review" step in .github/workflows/claude-code-review.yml changes:

  • anthropics/claude-code-action@beta becomes @v1.
  • The model pin is removed; the action's default model is used.
  • direct_prompt becomes prompt (the v1 input name). The five review criteria and closing instructions are word-for-word the same, with the repository and PR number added at the top.
  • track_progress: true keeps the review posted as a tracking comment, and claude_args gives an explicit tool allowlist: inline comments plus gh pr comment, gh pr diff, and gh pr view.

Triggers (PR opened/synchronize/reopened, and @claude comments), the claude-review job name, permissions, and the checkout step are unchanged.

This matches the configuration indextables/indextables_spark already runs, minus show_full_output, which is left off because this repository is public.

Testing

  • The YAML parses, and the step's inputs are exactly claude_code_oauth_token, track_progress, prompt, and claude_args.
  • The same @v1 configuration with no model pin completed a review successfully in indextables_spark on 2026-10-06.
  • track_progress was checked against the v1 action source and is accepted for both pull_request and issue_comment events.
  • Not run: actionlint, and the workflow itself, which can only run in Actions.

Note on this PR's own check

The action validates the workflow file against the version on the default branch, so claude-review is expected to fail or be rejected on this PR. The first real test is the next PR opened or updated after this merges. The check is not required for merging.

The claude-review check has failed on every pull request since the
pinned model, claude-sonnet-4-20250514, was retired: the API answers
404 not_found_error and the action exits after one turn, leaving an
error comment on the PR.

Removing the pin alone is not enough, because the workflow also used
the frozen @beta tag of the action. Move to @v1 with no model so the
action's default model is used, and translate the inputs to their v1
names: direct_prompt becomes prompt, with track_progress so the review
is still posted as a tracking comment, and an explicit tool allowlist
for inline comments and read-only gh pr commands.

Triggers, job name, permissions, and the review criteria are unchanged.
@rbrenton

rbrenton commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favour of #215, which replaces this workflow with the review-from-main version already live in indextables_spark (runs on Dependabot PRs, pass/fail verdict, no model pin).

@rbrenton rbrenton closed this Oct 8, 2026

This branch had an error being deployed

1 failed deployment
test-runners — bd488d66 Deployed Oct 6, 2026 by rbrenton via Build & Test (macOS ARM64) #126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant