Add mapping for IFs v8.54#23
Open
danielhuppmann wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the mapping started by @VassilisDaioglou in IAMconsortium/common-definitions#410, but it omits the model-name-prefix because the native regions are all countrIy names.
I double-checked the codes used by IFs v8.54 against the nomenclature.countries module (read the docs) and found the following inconsistencies:
Any chance to harmonise the IFs v8.54 reporting to use the correct alpha-3 codes?
Also, there is a discrepancy: in the mapping, the code "COG" is mapped to "Democratic Republic of the Congo", but according to https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3, COG stands for Congo and COD stands for "Democratic Republic of the Congo". Please double-check.
FYI @dc-almeida @lisahligono