-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(ci): unbreak workflow YAML and add a complete actions.lock #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| # Dormant push-email notification. ARMED by setting the repo variable | ||
| # PUSH_EMAIL_ENABLED=true (the single on/off switch). Addresses are pre-filled; | ||
| # sending needs the org SMTP secrets (SMTP_HOST/PORT/USER/PASS). Inherited by | ||
|
|
@@ -17,7 +18,7 @@ | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Send push notification email | ||
| uses: dawidd6/action-send-mail@v18 | ||
| uses: dawidd6/action-send-mail@v3.12.0 | ||
|
Check warning on line 21 in .github/workflows/push-email-notify.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK While correcting the version from v18 to v3.12.0 resolves potential startup failures, the action Try running the following prompt in your IDE agent:
|
||
| with: | ||
| server_address: ${{ secrets.SMTP_HOST }} | ||
| server_port: ${{ secrets.SMTP_PORT }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| # SPDX-License-Identifier: MPL-2.0 | ||
| # This workflow is managed by gh actions-lock. | ||
| # This workflow is managed by gh actions-lock. | ||
| # SPDX-FileCopyrightText: 2025 hyperpolymath | ||
|
|
||
| name: Release | ||
|
|
@@ -47,7 +48,7 @@ | |
| steps: | ||
| - uses: actions/checkout@v7.0.1 | ||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@6d9817901c499d6b02debbb57edb38d33daa680b # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
|
Check warning on line 51 in .github/workflows/release.yml
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The workflow has reverted from a secure SHA-pinned version to a mutable version tag (@v1). This makes the CI pipeline vulnerable to supply chain attacks. Pin to the specific commit hash corresponding to v1 to ensure immutability. Try running the following prompt in your IDE agent:
|
||
| with: | ||
| targets: ${{ matrix.target }} | ||
| - name: Install cross | ||
|
|
@@ -90,7 +91,7 @@ | |
| steps: | ||
| - uses: actions/checkout@v7.0.1 | ||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@6d9817901c499d6b02debbb57edb38d33daa680b # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
| - name: Install cargo-deb | ||
| run: cargo install cargo-deb | ||
| - name: Build .deb | ||
|
|
@@ -109,7 +110,7 @@ | |
| steps: | ||
| - uses: actions/checkout@v7.0.1 | ||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@6d9817901c499d6b02debbb57edb38d33daa680b # stable | ||
| uses: dtolnay/rust-toolchain@v1 | ||
| - name: Install cargo-generate-rpm | ||
| run: cargo install cargo-generate-rpm | ||
| - name: Build binary | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚪ LOW RISK
Nitpick: This line duplicates the existing 'managed by gh actions-lock' comment on line 2. Removing it will keep the workflow YAML clean.
Try running the following prompt in your IDE agent: