Skip to content

fix(ci): unbreak workflow YAML and add a complete actions.lock - #98

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking
Aug 27, 2026
Merged

fix(ci): unbreak workflow YAML and add a complete actions.lock#98
hyperpolymath merged 1 commit into
mainfrom
fix/workflow-dependency-locking

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Remediates GitHub Workflow Dependency Locking (public preview, no changelog entry), which rejects runs at startup_failure — zero jobs, no logs, nothing in REST or GraphQL. Full analysis: hyperpolymath/standards#657.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead → 0 startup_failure, 13 running.

Five steps, in order — each blocks the next

1. Unbreak the workflow YAML. Any permissions: carrying a scalar with an indented mapping under it:

permissions: read-all
  actions: read        # <- mapping under a scalar. Unparseable.

This reaches past the one file: gh actions-lock refuses to run when any workflow in the repo fails to parse, so the repo can never acquire a lockfile and can never self-heal.

2. Repin standards reusables off commits with no actions.lock. The rejection requires the callee to be covered at the pinned SHA — unsatisfiable at a pre-lockfile commit.

3. Generate the lockfile with gh actions-lock.

4. Hand-add the reusable-caller entries the tool omits, as '<path>': [].

⚠️ Measured across 218 repos: P(startup_failure | has lockfile) = 91.7% vs 15.8% without — because every workflow a lockfile omits is rejected. A partial lock is worse than none. Running gh actions-lock and stopping there is how this outage spread.

5. Restore SPDX-License-Identifier to line 1, which the tool displaces with its own banner and which the workflow-security linter greps via head -1.

Verified before this PR was opened

0 unparseable workflows · lockfile covers every workflow, no omissions · SPDX on line 1 in every file. The script refuses to push if any of the three fails.

🤖 Generated with Claude Code

Remediates GitHub Workflow Dependency Locking (public preview), which
rejects runs at startup_failure with zero jobs and no logs. See
hyperpolymath/standards#657.

Five steps, in order, because each blocks the next:

1. Unbroke any workflow whose `permissions:` carried a scalar with an
   indented mapping under it - blind-permissions-insertion damage. This
   matters beyond the one file: gh actions-lock refuses to run when ANY
   workflow in the repo fails to parse, so the repo could never acquire a
   lockfile and could never self-heal.

2. Repinned hyperpolymath/standards reusables off commits that have no
   actions.lock. The rejection requires the CALLEE to be covered at the
   pinned SHA, which is unsatisfiable at a pre-lockfile commit.

3. Generated the lockfile with gh actions-lock.

4. Hand-added the reusable-workflow caller entries the tool omits, as
   '<path>': []. Measured across 218 repos: P(startup_failure | has
   lockfile) = 91.7% vs 15.8% without, because every workflow a lockfile
   OMITS is rejected. A PARTIAL lock is worse than none - running
   gh actions-lock and stopping there is how this outage spread.

5. Restored SPDX-License-Identifier to line 1, which the tool displaces
   with its own banner and which the workflow-security linter greps with
   head -1.

Verified before push: 0 unparseable workflows, lockfile covers every
workflow with no omissions, SPDX on line 1 in every file.

Proven on hyperpolymath/anamnesis: 6 of 6 workflows dead -> 0
startup_failure, 13 running.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit f089a9c into main Aug 27, 2026
@hyperpolymath
hyperpolymath deleted the fix/workflow-dependency-locking branch August 27, 2026 10:33
@gitar-bot

gitar-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5d007004-875f-46e3-b97c-5f6aa60e01bb

📥 Commits

Reviewing files that changed from the base of the PR and between ba7ab3b and 4eda1a0.

⛔ Files ignored due to path filters (1)
  • .github/workflows/actions.lock is excluded by !**/*.lock
📒 Files selected for processing (15)
  • .github/workflows/aur-publish.yml
  • .github/workflows/codeql.yml
  • .github/workflows/container.yml
  • .github/workflows/dependabot-automerge.yml
  • .github/workflows/generator-generic-ossf-slsa3-publish.yml
  • .github/workflows/governance.yml
  • .github/workflows/hypatia-scan.yml
  • .github/workflows/instant-sync.yml
  • .github/workflows/language-policy.yml
  • .github/workflows/mirror.yml
  • .github/workflows/pages.yml
  • .github/workflows/push-email-notify.yml
  • .github/workflows/release.yml
  • .github/workflows/scorecard.yml
  • .github/workflows/secret-scanner.yml

📝 Walkthrough

Summary by CodeRabbit

  • Maintenance
    • Updated several automated build, release, security, mirroring and governance workflows to newer action versions.
    • Refreshed Rust toolchain setup used during release builds.
    • Updated email notification tooling for improved compatibility.
    • Standardised workflow management annotations and cleaned up duplicate or unnecessary header entries.
    • Refreshed pinned references for security scanning and reusable automation workflows.

Walkthrough

The change updates GitHub Actions workflow headers, reusable workflow commit pins, the email action version, and Rust toolchain references. Most edits affect comments or formatting only.

Changes

GitHub Actions workflow maintenance

Layer / File(s) Summary
Workflow header normalisation
.github/workflows/*.yml
Workflow headers add, remove, or consolidate the gh actions-lock management comment and blank lines.
Reusable workflow pin updates
.github/workflows/governance.yml, .github/workflows/hypatia-scan.yml, .github/workflows/mirror.yml, .github/workflows/scorecard.yml, .github/workflows/secret-scanner.yml
Reusable workflow references use updated commit pins.
Action reference updates
.github/workflows/push-email-notify.yml, .github/workflows/release.yml
The email action changes to v3.12.0. Release jobs use the dtolnay/rust-toolchain@v1 tag.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit checks each workflow line

Comments hop into order fine
Pins move safely, neat and bright
Rust tools change their tag tonight
The action files now look just right

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 2 high

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
Security 2 high

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While this PR attempts to stabilize the CI workflows and integrate actions-lock, it currently falls short of security standards. Codacy analysis indicates the PR is not up to standards, primarily due to the introduction of mutable action tags in sensitive pipelines. Specifically, reverting from commit SHAs to version tags in release.yml and push-email-notify.yml creates a supply chain risk that undermines the goal of using a lockfile.

Furthermore, the actions.lock file is absent from the provided diff, making it impossible to verify the completeness of the dependency locking or the validity of the manual entries mentioned in the requirements. A systemic issue with the header restoration script has also caused a duplicate comment line on line 3 of almost every modified file, which should be cleaned up before merging.

About this PR

  • The actions.lock file is excluded from the diff. This prevents verification of the pinned SHAs and the manual entries required for reusable-caller dependencies. Ensure this file is included in the PR.
  • A redundant header comment '# This workflow is managed by gh actions-lock.' has been added to line 3 of all workflow files, duplicating the entry on line 2. This suggests a misconfiguration in the automation used to restore SPDX headers.

Test suggestions

  • Verify all workflow YAML files are valid and parseable
  • Verify actions.lock contains entries for all identified workflow dependencies
  • Verify SPDX-License-Identifier is the first line of every .yml file
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify all workflow YAML files are valid and parseable
2. Verify actions.lock contains entries for all identified workflow dependencies
3. Verify SPDX-License-Identifier is the first line of every .yml file

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

steps:
- name: Send push notification email
uses: dawidd6/action-send-mail@v18
uses: dawidd6/action-send-mail@v3.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

While correcting the version from v18 to v3.12.0 resolves potential startup failures, the action dawidd6/action-send-mail should be pinned to an immutable commit SHA rather than a mutable tag. This is critical for actions handling SMTP credentials.

Try running the following prompt in your IDE agent:

Lookup the commit SHA for dawidd6/action-send-mail@v3.12.0 and update the 'uses' entry at line 21 in .github/workflows/push-email-notify.yml to use the SHA instead of the tag.

See Issue in Codacy

- uses: actions/checkout@v7.0.1
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@6d9817901c499d6b02debbb57edb38d33daa680b # stable
uses: dtolnay/rust-toolchain@v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 HIGH RISK

The workflow has reverted from a secure SHA-pinned version to a mutable version tag (@v1). This makes the CI pipeline vulnerable to supply chain attacks. Pin to the specific commit hash corresponding to v1 to ensure immutability.

Try running the following prompt in your IDE agent:

Find the commit SHA for dtolnay/rust-toolchain@v1 and replace the tag at line 51 in .github/workflows/release.yml with the corresponding SHA.

See Issue in Codacy

@@ -1,5 +1,6 @@
# SPDX-License-Identifier: MPL-2.0
# This workflow is managed by gh actions-lock.
# This workflow is managed by gh actions-lock.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: This line duplicates the existing 'managed by gh actions-lock' comment on line 2. Removing it will keep the workflow YAML clean.

Try running the following prompt in your IDE agent:

Remove the duplicate '# This workflow is managed by gh actions-lock.' comment line at the top of all .yml files in .github/workflows/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant