chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #22
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#22hyperpolymath wants to merge 3 commits into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review
|
| Compact |
|
Important
Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
|
|
||
| sed -i 's/{{AUTHOR}}/Jane Doe/g' $(grep -rl '{{AUTHOR}}' .) | ||
| sed -i 's/{{AUTHOR_EMAIL}}/jane@example.org/g' $(grep -rl '{{AUTHOR_EMAIL}}' .) | ||
| sed -i 's/{{OWNER}}/my-org/g' $(grep -rl '{{OWNER}}' .) | ||
| sed -i 's/{{PROJECT_NAME}}/my-project/g' $(grep -rl '{{PROJECT_NAME}}' .) | ||
| sed -i 's/{{PROJECT}}/MY_PROJECT/g' $(grep -rl '{{PROJECT}}' .) | ||
| sed -i 's/Jonathan D.A. Jewell/Jane Doe/g' $(grep -rl 'Jonathan D.A. Jewell' .) | ||
| sed -i 's/j.d.a.jewell@open.ac.uk/jane@example.org/g' $(grep -rl 'j.d.a.jewell@open.ac.uk' .) | ||
| sed -i 's/hyperpolymath/my-org/g' $(grep -rl 'hyperpolymath' .) | ||
| sed -i 's/Overview/my-project/g' $(grep -rl 'Overview' .) | ||
| sed -i 's/JULIA_ECOSYSTEM/MY_PROJECT/g' $(grep -rl 'JULIA_ECOSYSTEM' .) | ||
| sed -i 's/{{project}}/my_project/g' $(grep -rl '{{project}}' .) | ||
| sed -i 's/{{REPO}}/my-project/g' $(grep -rl '{{REPO}}' .) | ||
| sed -i 's/{{FORGE}}/github.com/g' $(grep -rl '{{FORGE}}' .) | ||
| sed -i "s/{{CURRENT_YEAR}}/$(date +%Y)/g" $(grep -rl '{{CURRENT_YEAR}}' .) | ||
| sed -i "s/{{CURRENT_DATE}}/$(date +%Y-%m-%d)/g" $(grep -rl '{{CURRENT_DATE}}' .) | ||
| sed -i 's/julia-ecosystem/my-project/g' $(grep -rl 'julia-ecosystem' .) | ||
| sed -i 's/github.com/github.com/g' $(grep -rl 'github.com' .) | ||
| sed -i "s/2026/$(date +%Y)/g" $(grep -rl '2026' .) | ||
| sed -i "s/2026-08-05/$(date +%Y-%m-%d)/g" $(grep -rl '2026-08-05' .) |
There was a problem hiding this comment.
⚠️ Bug: PLACEHOLDERS.md sed commands rewritten into no-ops/destructive
The substitution pass ran over PLACEHOLDERS.md itself, rewriting the literal token names in its "Manual Replace" recipe. The instructions are now broken or dangerous: sed -i 's/github.com/github.com/g' $(grep -rl 'github.com' .) and sed -i 's/hyperpolymath/my-org/g' $(grep -rl 'hyperpolymath' .) are no-ops or over-broad, and sed -i "s/2026/$(date +%Y)/g" $(grep -rl '2026' .) will rewrite every occurrence of 2026 (and github.com) anywhere in the tree if a user follows them. The reference table below is likewise corrupted (e.g. the {{AUTHOR}} row now reads | Jonathan D.A. Jewell | Full legal name | ... |), so the file no longer documents which tokens exist. Exclude PLACEHOLDERS.md (and its equivalents in the other packages) from token substitution and restore the literal {{...}} references.
Was this helpful? React with 👍 / 👎
|
|
||
| **Problem:** Ten files still contain unreplaced `{{PROJECT}}`, `{{project}}`, | ||
| `{{OWNER}}`, `{{REPO}}`, `{{FORGE}}`, `{{SECURITY_EMAIL}}`, `{{PGP_FINGERPRINT}}`, | ||
| `{{PGP_KEY_URL}}`, `{{WEBSITE}}`, `{{CURRENT_YEAR}}`, `{{PROJECT_NAME}}`, | ||
| `{{CONDUCT_EMAIL}}`, `{{CONDUCT_TEAM}}`, `{{RESPONSE_TIME}}`, `{{MAIN_BRANCH}}`, | ||
| **Problem:** Ten files still contain unreplaced `JULIA_ECOSYSTEM`, `{{project}}`, | ||
| `hyperpolymath`, `julia-ecosystem`, `github.com`, `{{SECURITY_EMAIL}}`, `{{PGP_FINGERPRINT}}`, | ||
| `{{PGP_KEY_URL}}`, `{{WEBSITE}}`, `2026`, `Overview`, | ||
| `j.d.a.jewell@open.ac.uk`, `{{CONDUCT_TEAM}}`, `{{RESPONSE_TIME}}`, `main`, | ||
| and `{{LICENSE}}` markers from the RSR template. These files are: | ||
|
|
||
| 1. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/build.zig` -- `{{PROJECT}}`, `{{project}}` | ||
| 2. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/src/main.zig` -- `{{PROJECT}}`, `{{project}}` | ||
| 3. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/test/integration_test.zig` -- `{{PROJECT}}`, `{{project}}` | ||
| 4. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Types.idr` -- `{{PROJECT}}` | ||
| 5. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Layout.idr` -- `{{PROJECT}}` | ||
| 6. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Foreign.idr` -- `{{PROJECT}}`, `{{project}}` | ||
| 7. `/var$REPOS_DIR/KnotTheory.jl/ABI-FFI-README.md` -- `{{PROJECT}}`, `{{project}}`, `{{LICENSE}}` | ||
| 8. `/var$REPOS_DIR/KnotTheory.jl/SECURITY.md` -- `{{OWNER}}`, `{{REPO}}`, `{{SECURITY_EMAIL}}`, `{{PGP_FINGERPRINT}}`, `{{PGP_KEY_URL}}`, `{{WEBSITE}}`, `{{CURRENT_YEAR}}`, `{{PROJECT_NAME}}` | ||
| 9. `/var$REPOS_DIR/KnotTheory.jl/CODE_OF_CONDUCT.md` -- `{{PROJECT_NAME}}`, `{{OWNER}}`, `{{REPO}}`, `{{CONDUCT_EMAIL}}`, `{{CONDUCT_TEAM}}`, `{{RESPONSE_TIME}}`, `{{CURRENT_YEAR}}`, `{{FORGE}}` | ||
| 10. `/var$REPOS_DIR/KnotTheory.jl/CONTRIBUTING.md` -- `{{FORGE}}`, `{{OWNER}}`, `{{REPO}}`, `{{MAIN_BRANCH}}` | ||
| 1. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/build.zig` -- `JULIA_ECOSYSTEM`, `{{project}}` | ||
| 2. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/src/main.zig` -- `JULIA_ECOSYSTEM`, `{{project}}` | ||
| 3. `/var$REPOS_DIR/KnotTheory.jl/ffi/zig/test/integration_test.zig` -- `JULIA_ECOSYSTEM`, `{{project}}` | ||
| 4. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Types.idr` -- `JULIA_ECOSYSTEM` | ||
| 5. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Layout.idr` -- `JULIA_ECOSYSTEM` | ||
| 6. `/var$REPOS_DIR/KnotTheory.jl/src/abi/Foreign.idr` -- `JULIA_ECOSYSTEM`, `{{project}}` | ||
| 7. `/var$REPOS_DIR/KnotTheory.jl/ABI-FFI-README.md` -- `JULIA_ECOSYSTEM`, `{{project}}`, `{{LICENSE}}` | ||
| 8. `/var$REPOS_DIR/KnotTheory.jl/SECURITY.md` -- `hyperpolymath`, `julia-ecosystem`, `{{SECURITY_EMAIL}}`, `{{PGP_FINGERPRINT}}`, `{{PGP_KEY_URL}}`, `{{WEBSITE}}`, `2026`, `Overview` |
There was a problem hiding this comment.
⚠️ Quality: SONNET-TASKS.md replace-instructions turned into identity no-ops
The pass substituted token strings inside the task docs that describe how to replace those tokens, producing meaningless instructions such as "Replace hyperpolymath with hyperpolymath", "Replace julia-ecosystem with KnotTheory.jl", "Replace github.com with github.com" and "Replace 2026 with 2026". This destroys the information these docs carried (which literal {{TOKEN}} to find), and in several places the "Problem" prose now claims files "still contain hyperpolymath, github.com" as if those were placeholders. These files should have been excluded from substitution; restore the literal {{OWNER}}/{{REPO}}/{{FORGE}}/{{PROJECT}}/{{CURRENT_YEAR}} references so the task instructions remain actionable.
Was this helpful? React with 👍 / 👎
|
|
||
| [methodology.state-validation] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "JULIA_ECOSYSTEM", "rsr-template-repo"] |
There was a problem hiding this comment.
💡 Bug: methodology reject-list now flags the substituted JULIA_ECOSYSTEM value
reject-if-contains was changed from {{PROJECT}} to JULIA_ECOSYSTEM (methodology.a2ml:104). The intent of the rule is to reject state files that still carry unfilled template markers, but JULIA_ECOSYSTEM is now the legitimate substituted project identifier used across the estate (e.g. the ffi/zig files). Any STATE.a2ml that legitimately names the ecosystem would now be rejected as corrupt/template. The rule applies only to state files so impact is limited, but the substitution is self-defeating — keep a template-marker token (e.g. {{PROJECT}}) in the reject list rather than the real value.
Was this helpful? React with 👍 / 👎
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
…t a value
The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.
Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.
Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Closing in favour of a reworked substituter — hyperpolymath/standards#590. This sweep filled Those are the scripts whose job is to perform template substitution. Filling the left-hand side of their own Four further shapes came out of the same cause:
The rule plain replacement cannot express: a placeholder is sometimes a value to fill and sometimes the subject being discussed. standards#590 encodes that distinction and is tested against this exact corruption (9/9, the first three cases reproducing it). Nothing here is lost — the placeholder filling will be redone with that tool. Closing rather than fixing forward because repairing 289 branches individually would repeat the mistake at the same scale. |
1 participant
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code