Skip to content

Gate the fallback stream counter on not(direct_arrow_insert) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austin-barrington merged 1 commit into from
Oct 17, 2026
Merged

Gate the fallback stream counter on not(direct_arrow_insert) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/arrow_insert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
//! [`Connection::register_arrow_array`](crate::connection::Connection::register_arrow_array),
//! and `INSERT INTO … SELECT * FROM ArrowStream('name')`.

#[cfg(not(direct_arrow_insert))]
use std::sync::atomic::{AtomicU64, Ordering};

use arrow::array::RecordBatchReader;
Expand All @@ -18,6 +19,10 @@ use crate::connection::Connection;
use crate::error::Result;
use crate::format::OutputFormat;

/// Names the registered stream when the engine cannot insert an Arrow array
/// directly. Built only then: with `direct_arrow_insert` it was unused, and a
/// `-D warnings` build against such an engine failed.
#[cfg(not(direct_arrow_insert))]
static FALLBACK_STREAM_SEQ: AtomicU64 = AtomicU64::new(0);

/// Owns Arrow C Data Interface structs for the lifetime of a registration or insert.
Expand Down