Repository navigation
Gate the fallback stream counter on not(direct_arrow_insert) - #2
Merged
Merged
Conversation
With an engine that inserts Arrow arrays directly (libchdb 26.9.0), FALLBACK_STREAM_SEQ and its Ordering import were unused, and a build with RUSTFLAGS=-D warnings failed on them. hyperbytedb's CI builds this crate that way against the latest engine, so its Clippy job failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Against an engine with
chdb_insert_arrow_array(libchdb 26.9.0),FALLBACK_STREAM_SEQand itsOrderingimport are unused, so aRUSTFLAGS=-D warningsbuild fails. hyperbytedb's CI builds this crate that way against the latest engine (its Clippy job on hyperbyte-cloud/hyperbytedb#116).Both now carry the same
#[cfg(not(direct_arrow_insert))]as their only use. Builds with-D warningsagainst 26.9.0 (direct insert) and the older local engine (fallback).