fix: make prefix mode work on Windows - #119
Merged
Merged
Conversation
|
🎉 This PR is included in version 2.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves
numux --prefixon Windows for parallel verify-style DAGs and fixes everything found.What was broken (each proven on a windows-2025 runner)
bun run docscrashed: Windows checks out CRLF, the marker regex expects LF (Marker not found: subcommands).--prefix.terminalspawn is POSIX-only on 1.3.12; one run hung to the 10-minute timeout.cmd.exe, sobun -e "..."ran as barebun. Failure detection was fully broken.Changes
src/index.ts: TUI loads via dynamic import only in TUI mode;execuses the shared shell helper;logs <proc>streams the file in chunks instead of spawningcat.src/process/runner.ts: win32 spawnscmdwith piped stdio pumped into the existing handlers; direct kill instead of negative-PID group kill. POSIX path untouched.src/utils/shell.ts(new, tested):shellArgv(sh -cvs Node-stylecmd /d /s /c "cmd") andshellSpawnOptions(windowsVerbatimArguments, which is what preserves quotes and exit codes).scripts/generate-docs.ts: CRLF-tolerant reads..gitattributes:eol=lf, matching the Biome LF rule.windows-prefixjob runningscripts/windows-prefix-smoke.ts(parallel DAG + dependsOn ordering + failing exit code + skip propagation, allbun -ecommands);workflow_dispatchtrigger; commitlint PR-only.Proof
Green run (check + windows-prefix, 10/10 smoke assertions on win32): https://github.com/hyldmo/numux/actions/runs/34586422554
Caveat: only prefix mode is proven. The TUI still loads native modules that crash Bun on Windows, so recommend
--prefixthere.