fix: split TUI into lazy chunk so prefix never loads natives on Windows - #121
Merged
Merged
Conversation
|
🎉 This PR is included in version 2.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #119: farero reported
yarn verify(2.19.1,--prefix,true-shorthand config) still segfaults at startup on Windows, fault inghostty-opentui.node.Root cause (not the config shape)
Published 2.19.1
dist/numux.jsinlinessrc/ui/app.tsand keeps a top-levelfrom "ghostty-opentui"import.Bun.buildwithoutsplitting: trueemits a single chunk, so the #119 source-level dynamic import was defeated by hoisting: every invocation, including--version, evaluates natives at startup and dies on Windows. Thetrueshorthand is pure string building (lint: true→bun run lint) and never touched natives; my first smoke only ran source, which is why it stayed green.Changes
build.ts:splitting: true(+ stable chunk naming). Verified:dist/numux.jshas zero ghostty/opentui references; natives live only in lazy chunks behind runtimeimport().scripts/windows-prefix-smoke.ts: every scenario now runs against bothsrc/index.tsand the built bundle (hard-fails ifdistis missing), plus a newtrue-shorthand case with isolated package.json. 28 assertions, green locally on both entries.ci.yml: windows job builds before smoking.Proof pending
Windows dispatch on this branch will show the bundle phase green. After merge, semantic-release cuts the fix version for farero to consume.