Repository navigation
Conversation
…drop review days and strict mode (#44)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part B of #44, stacked on #45. Retarget the base to
mainonce #45 is merged.One review date
review_datefield, and its "on or after effective date" check is gone.items.review_byis the only review date.025_single_review_date.sql:review_dateintoreview_bywherereview_byis empty;review_datefrom the Policy working row and both published copies, with the version and review-by triggers paused so it does not count as a new publish;review_dateget "Unknown field(s): review_date".No per-library knobs
POST /libraries/:id/freshness;libraries.review_daysandlibraries.strict_freshnesscolumns;library_review_days()anditem_review_by_for()(the JSON-parsing one).warningline. The refusal,withheldandstaleRefusal/withoutRefusedpaths are removed.Also removed: the dead
policyItemSchemaandpolicyItemFields(an older Policy form), and the unusedlabel.checkboxCSS.Demo seed: Help Desk Runbooks is a General library, so it now sets review-by dates per item. Account Lockout is set overdue and Incident Response due in 6 days, as before, and the other three get +90 days.
Tests
review_by, stripsreview_datefrom the details, snapshot and schema, and leaves the version unchanged.