Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part C of #44, stacked on #46. Retarget the base to
mainonce #46 is merged.Search already matched and ranked aliases exactly like labels, so this keeps one list: "phished" or "suspicious email" is now just a label.
Migration
026_aliases_into_labels.sqlitems_liveview and recreates it withoutaliases(CREATE OR REPLACE cannot drop a column), then dropsitems.aliases.runbook, security, phishingplus aliasesphished, phishing, suspicious emailtorunbook, security, phishing, phished, suspicious email, with the published version unchanged.Removed
aliasescolumn, field and parsing: models, snapshots, writes, lookup, shelf search and the vocabulary.formAliases.aliases:line in item output, the Markdown export line, and the "Aliases" row in "What changed".add_aliasesandremove_aliasesonsuggest_labels. The tool stays, withadd_labels,remove_labels,reasonandexpected_revision.Tests
item-aliases.test.tsis renamed tolabel-suggestions.test.tsand uses labels: search, typos, Review Lock and Unlock, Cancel, refusals.suggest_labelshas no alias params, plus a migration 026 test: merge into the working row and published copy, version unchanged, noaliasescolumn onitemsoritems_live, and the phished search still answers.published-while-pendingreplay now re-runs only 018.