Skip to content

Simplify agent contract: cite_as-only citations, no editor version field (#44, A) - #45

Open
hkrlogic wants to merge 1 commit into
mainfrom
simplify/agent-contract
Open

hkrlogic wants to merge 1 commit into
mainfrom
simplify/agent-contract

Conversation

@hkrlogic

Copy link
Copy Markdown
Owner

Part A of #44. First of three stacked PRs (A → B → C); merge in that order.

Citations

  • A full item now ends with cite_as, then review_by only when the item has a review-by date, and warning only when it is past that date.
  • The version, published_at, updated_at, published_by, url and stale lines are removed, because cite_as already carries the version, publish day, publisher and URL.
  • JSON results (lists, search_shelf) carry the same keys in citation.
  • The demo VPN runbook's block shrinks from 444 to about 230 characters.

Editor meta

  • Removed the version: published|draft result field; status and has_pending_changes already say this.
  • revision stays and is documented as an opaque token for expected_revision.
  • The open_item version argument is unchanged.

Queries

  • The citation query also reads the working-row revision, so itemWire no longer re-reads the item to get it.
  • Single-item answers fetch the citation once instead of twice (once for the strict check, once for the wire).

Review-by route

  • Kept. POST /items/:id/review-by is used by the item page's "Set date" form, so the UI does use it.
  • After PR B it is also the only way to give a General-library item a review date.

Tests

  • Citation, freshness and published-while-pending assertions updated.
  • Typecheck, lint and the full test suite pass (422/422).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant