Repository navigation
Conversation
…field, one citation query per item (#44)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part A of #44. First of three stacked PRs (A → B → C); merge in that order.
Citations
cite_as, thenreview_byonly when the item has a review-by date, andwarningonly when it is past that date.version,published_at,updated_at,published_by,urlandstalelines are removed, becausecite_asalready carries the version, publish day, publisher and URL.search_shelf) carry the same keys incitation.Editor meta
version: published|draftresult field;statusandhas_pending_changesalready say this.revisionstays and is documented as an opaque token forexpected_revision.open_itemversionargument is unchanged.Queries
itemWireno longer re-reads the item to get it.Review-by route
POST /items/:id/review-byis used by the item page's "Set date" form, so the UI does use it.Tests