Skip to content

Forget the exit cancel of a session whose bridges stopped #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abonneth merged 1 commit into from
Oct 8, 2026
Merged

Forget the exit cancel of a session whose bridges stopped #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/hai_agents_local/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ def _live_sessions(self) -> typing.List[str]:
for session_id, bridge_ids in list(self._owned_bridges.items()):
if not serving_bridges(bridge_ids):
del self._owned_bridges[session_id]
_deregister_exit_cancel(session_id)
return list(self._owned_bridges)

def _track(self, session: typing.Any, started: typing.List[str]) -> None:
Expand Down
3 changes: 3 additions & 0 deletions tests/test_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,8 +1087,10 @@ async def async_cancel(*args, **kwargs):
@pytest.mark.parametrize("asynchronous", [False, True])
async def test_close_cancels_only_sessions_still_served(monkeypatch, asynchronous):
from hai_agents import AsyncClient
from hai_agents_local import sessions as module

cancelled = []
monkeypatch.setattr(module, "_exit_cancels", {"ended": lambda: cancelled.append("ended at exit")})

def respond(request: httpx.Request) -> httpx.Response:
session_id = request.url.path.rsplit("/", 1)[1]
Expand All @@ -1110,5 +1112,6 @@ def respond(request: httpx.Request) -> httpx.Response:
else:
sessions.cancel_session(id="unbridged")
sessions.close()
module._cancel_sessions_at_exit()
assert cancelled == ["unbridged", "live", "evicted"]
assert sessions._owned_bridges == {}
Loading