Skip to content

Forget the exit cancel of a session whose bridges stopped - #245

Merged
abonneth merged 1 commit into
mainfrom
antoine/forget-exit-cancel
Oct 8, 2026
Merged

abonneth merged 1 commit into
mainfrom
antoine/forget-exit-cancel

Conversation

@abonneth

@abonneth abonneth commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Made with Cursor


Note

Low Risk
Small bookkeeping change in local session cleanup; tests cover the exit-cancel registry behavior.

Overview
When _live_sessions() drops a session because no bridges are still serving, it now also calls _deregister_exit_cancel so that session is removed from the interpreter-exit cancel registry.

That avoids exit-time (or test-simulated _cancel_sessions_at_exit) retries for sessions whose local bridges already stopped and were already handled. test_close_cancels_only_sessions_still_served was updated to seed a fake exit hook for an “ended” session and assert it is not invoked after close when that session is forgotten.

Reviewed by Cursor Bugbot for commit 68f5b91. Bugbot is set up for automated code reviews on this repo. Configure here.

@abonneth
abonneth requested a review from adeprezh as a code owner October 7, 2026 23:02
@abonneth
abonneth merged commit a27e75c into main Oct 8, 2026
6 checks passed
@abonneth
abonneth deleted the antoine/forget-exit-cancel branch October 8, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants