Add a :meta task option to markdown, render, and collection#116
Merged
podviaznikov merged 5 commits intohashobject:masterfrom Dec 7, 2016
Merged
Add a :meta task option to markdown, render, and collection#116podviaznikov merged 5 commits intohashobject:masterfrom
:meta task option to markdown, render, and collection#116podviaznikov merged 5 commits intohashobject:masterfrom
Conversation
Allows more control of entry metadata in the case of `markdown`, and any control at all in the case of `collection`
bhagany
changed the title
:meta task option to markdown and collection:meta task option to markdown, render, and collection
podviaznikov
approved these changes
Dec 2, 2016
Member
podviaznikov
left a comment
podviaznikov
left a comment
There was a problem hiding this comment.
I like having those smaller PRs that implement one feature
Member
|
Small conflict |
Contributor
Author
|
and fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows more control of entry metadata in the case of
markdown, and anycontrol at all in the cases of
renderandcollection, following @MartyGentillon and @martinklepsch, in #109 (comment) and #114 (comment), respectively.Having
:metainrenderisn't terribly useful now, but in the spirit of #109, it would be consistent to have this option on any task that deals with:content.