Add :io.perun/trace to file metadata#117
Merged
podviaznikov merged 5 commits intohashobject:masterfrom Dec 7, 2016
Merged
Conversation
Each built-in task that modifies file metadata conjes a keyword onto the `:perun/trace` vector. This will aid in debugging, and possibly have applications in tasks.
Contributor
👍 One suggestion would be |
Contributor
Author
I was going to make a case for the shorter thing, but |
bhagany
changed the title
:perun/trace to file metadata:io.perun/trace to file metadata
Member
|
Small conflict, will merge when resolved |
Contributor
Author
|
Okay, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each built-in task that modifies file metadata conjes a keyword onto the
:perun/tracevector. This will aid in debugging, and possibly have applications in tasks.Following @MartyGentillon here: #113 (comment). Two notes:
:perun/tracethan with:include-rssand:include-atom, because:perun/tracefeels like a different kind of metadata. For the values in the vector, I went with:perun/namespaced keywords as well, because 3rd party code may want to hook into thetracefunctionality. I still think that namespaced keywords are a good idea pretty much everywhere in perun, fwiw.render, don't usetrace, because they don't currently modify metadata. If Add a:metatask option tomarkdown,render, andcollection#116 gets merged before this one, I'll modify this PR totracerenderas well.