Skip to content

Fix receipt admin reads without upfront relation locks - #658

Merged
hardbyte merged 6 commits into
release/0.6.6from
brian/fix-receipt-admin-reads-no-prelocks-0.6
Nov 6, 2026
Merged

hardbyte merged 6 commits into
release/0.6.6from
brian/fix-receipt-admin-reads-no-prelocks-0.6

Conversation

@hardbyte

@hardbyte hardbyte commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Running jobs represented by compact or legacy receipt claims were missing from admin job lists and kind counts until their leases materialized. Include those claims with the existing scope, cursor, kind, tag and queue filters, and exclude tombstoned source rows when hydrating jobs moved between ready lanes.

Prepared on #655 and the merged #657. This splits the receipt-read changes from #652/#653 and adds no upfront relation locks. The remaining point-read/list-hydration limitation is documented: if prune truncates a partition during the read, a completed job can briefly appear available or missing; retry with a fresh read.

Validation: both Rust workspaces passed formatting, all-target/all-feature Clippy with warnings denied, and workspace builds, including after composition with #655. On PostgreSQL18, eight public-API cases passed across compact, row-local and materialized receipts, moved-row multiplicity, list/reference equivalence and full inserted-job count conservation. Both reference/conservation cases passed again on the composed head. Matched old-source controls reproduced the duplicate moved-row projection and omitted compact-receipt list; the materialized negative control passed. Root and an independent reviewer checked the source. Full CI passed all29jobs at 0e6b326a.

Prevent the compact-member range membership check from becoming a broad
anti-join over retained closure batches. Preserve every identity and
closure predicate and the existing result semantics.
Closure writers preserve the original claim slot. Match that slot in
row-local receipt closure checks while retaining global receipt identity.
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 518b251e-b715-4ca8-955a-39f7676627f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T22:17:53.482757Z b3a850f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hardbyte hardbyte added the full-ci Run the full CI matrix (Python build+test, E2E) on this PR label Nov 6, 2026 — with ChatGPT Codex Connector
@hardbyte
hardbyte merged commit 838443d into release/0.6.6 Nov 6, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Run the full CI matrix (Python build+test, E2E) on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant