Skip to content

fix: include running receipt claims in 0.6 admin reads - #653

Closed
hardbyte wants to merge 3 commits into
release/0.6.6from
brian/fix-receipt-admin-reads-0.6
Closed

hardbyte wants to merge 3 commits into
release/0.6.6from
brian/fix-receipt-admin-reads-0.6

Conversation

@hardbyte

@hardbyte hardbyte commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Running jobs held by compact or row-local receipt claims disappear from the 0.6 admin job list and kind counts even while the queue overview reports them. Backport the receipt-aware projections from main so both receipt formats appear until closure or lease materialization, without counting the same attempt twice.

Builds on #652 and relates to #416. The new list source applies the requested state, kind, queue and cursor with the existing result limit; this does not bound scans of retained receipt history. No schema changes.

Validation:

  • On unchanged fix(queue-storage): preserve moved-attempt reads and snapshots (0.6) #652 queries, both receipt modes fail the new scoped list regression with an empty result; the materialized-lease control passes on PostgreSQL 17 and 18.
  • With the fix, all nine focused tests pass on each version: scoped filters/paging, moved-row hydration, materialization/closure, existing admin counts and aged leases.
  • cargo fmt --all, all-target/all-feature Clippy with warnings denied, and workspace build pass.

The independent conservation guard now includes open receipt jobs. Its older bookkeeping subtracted those claims even though this change correctly lists them: the failed PG18 CI reported 19 versus 16 after actual/reference JSON equality had already passed. The fixture retains every real claim operation and compares each kind to its full retained-insert ledger, including explicit deletion adjustments.

With unchanged product code, both existing equivalence tests pass on PostgreSQL 17 and 18. Restoring parent #652's admin implementation under the identical new guard fails with 16 versus 19 on both versions, proving the guard still catches omitted receipt jobs. Product bytes were restored exactly before required fmt, all-target/all-feature Clippy and workspace build. The earlier nine functional cases were not repeated for this test-only correction; fresh exact-head full CI is pending.

Backport receipt-aware job list projections and kind counts for compact
and row-local claims. Preserve exact live attempt hydration and closure,
terminal and materialization exclusions. Cover scope, paging and disposition
for both receipt formats and the materialized lease control.
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@hardbyte hardbyte added the full-ci Run the full CI matrix (Python build+test, E2E) on this PR label Nov 6, 2026 — with ChatGPT Codex Connector
@hardbyte

hardbyte commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #658, which shipped in 0.6.14 (open receipt jobs appear in admin reads without prelocks).

@hardbyte hardbyte closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-ci Run the full CI matrix (Python build+test, E2E) on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant