Repository navigation
Conversation
Backport receipt-aware job list projections and kind counts for compact and row-local claims. Preserve exact live attempt hydration and closure, terminal and materialization exclusions. Cover scope, paging and disposition for both receipt formats and the materialized lease control.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
Superseded by #658, which shipped in 0.6.14 (open receipt jobs appear in admin reads without prelocks). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running jobs held by compact or row-local receipt claims disappear from the 0.6 admin job list and kind counts even while the queue overview reports them. Backport the receipt-aware projections from main so both receipt formats appear until closure or lease materialization, without counting the same attempt twice.
Builds on #652 and relates to #416. The new list source applies the requested state, kind, queue and cursor with the existing result limit; this does not bound scans of retained receipt history. No schema changes.
Validation:
cargo fmt --all, all-target/all-feature Clippy with warnings denied, and workspace build pass.The independent conservation guard now includes open receipt jobs. Its older bookkeeping subtracted those claims even though this change correctly lists them: the failed PG18 CI reported 19 versus 16 after actual/reference JSON equality had already passed. The fixture retains every real claim operation and compares each kind to its full retained-insert ledger, including explicit deletion adjustments.
With unchanged product code, both existing equivalence tests pass on PostgreSQL 17 and 18. Restoring parent #652's admin implementation under the identical new guard fails with 16 versus 19 on both versions, proving the guard still catches omitted receipt jobs. Product bytes were restored exactly before required fmt, all-target/all-feature Clippy and workspace build. The earlier nine functional cases were not repeated for this test-only correction; fresh exact-head full CI is pending.