Repository navigation
fix: smoke test the release binary with --paging never. - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更理由
v0.10.0 の release workflow(run 36984370851)が、バイナリを実行できる 3 target のスモークテストで失敗した。スモークテストが #14 で廃止した
--no-pager --plainを使っていて、usage error(exit 2)になったため。Release ジョブは実行されておらず、何も公開されていない。変更内容
.github/workflows/release.ymlのスモークテストを--paging never --color neverに置き換えた。影響範囲
.github/workflows/release.ymlのみ。確認手順
.github/と.claude/を含む)を検索した。旧フラグが残っているのは、それを拒否することを確かめるテスト(src/cli.rs・tests/cli.rs)だけ。マージ後
タグは打ち直さない。既存の
v0.10.0を渡して再実行する。手動実行のときはmainの workflow 定義が使われ、checkout されるのは渡したタグのコードになる。gh workflow run release.yml --ref main -f tag=v0.10.0