Repository navigation
ci: run the release smoke test on every pull request. - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更理由
v0.10.0 の release workflow が、スモークテストで廃止済みのフラグ(
--no-pager --plain)を使っていたために失敗した(#15 で修正済み)。スモークテストはrelease.ymlにしか無く、タグを push するまで実行されないため、PR の段階では気付けなかった。変更内容
.github/scripts/smoke-test.shに移した。release.yml: 各 native target の release バイナリに対して、このスクリプトを実行する(中身は前と同じ)。ci.yml: test ジョブ(Linux・macOS・Windows)で、cargo testの後に debug ビルドしたバイナリに対して同じスクリプトを実行する。コマンドが 1 箇所にしか無いので、フラグを変えて壊れるときは PR の CI で落ちる。
影響範囲
.github/scripts/smoke-test.sh(新規)、.github/workflows/ci.yml、.github/workflows/release.ymlcargo testがビルドした成果物を再利用するので、ほぼ増えない想定)。確認手順
cargo build --locked→bash .github/scripts/smoke-test.sh target/debug/mdvuが exit 0 になった。target/debug/mdvuをmdvu.exeとして起動できることもここで確かめる。release.ymlの変更は、次のタグを push するまで実行されない。