Repository navigation
fix(config): clarify phonebook source and independent SGA changes - #174
Merged
lollox80 merged 1 commit intoOct 14, 2026
Merged
Conversation
Collaborator
|
LGTM. The summary now matches what On our 40515 we download from the Vimar cloud, and the old summary still explained the PICG with "rubrica da file", so thanks for this one. |
Contributor
Author
|
Tested on a 40517, Home Assistant 2026.8.3 Container, with all four PRs installed together. The summary correctly identifies “Vimar cloud” as the source. After changing only SGA, it proposes updating sga_target to 61000 while keeping PICG 60001. After confirmation, the settings show those values. 
|
lollox80
added a commit
to andreacasarin/ha-vimar-intercom
that referenced
this pull request
Oct 14, 2026
Resolve the conflicts with ha-vimar#174 by keeping both sides: the flow's _internal_panel_suggestion and _phonebook_source attributes, and the internal panel tests next to the import summary test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMtKjPuZNEaX23BpL9AsaA
lollox80
added a commit
that referenced
this pull request
Oct 14, 2026
Resolve the conflict in tests/test_config_flow_steps.py by keeping both sides: the outgoing video option tests and the internal panel and import summary tests from #173 and #174. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMtKjPuZNEaX23BpL9AsaA
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The phonebook confirmation summary says that a changed SGA will update both sga_target and picg_target, although the save logic correctly preserves an independently configured PICG. It also calls a cloud download an import from a file when describing the preserved PICG.
Make the SGA summary refer only to sga_target, make the missing-PICG explanation independent of the source, and display the actual phonebook source (Tab, Vimar cloud or rubrica.db). Reset stale REST PICG information when importing an uploaded file. The source is flow-local; it is not stored in the config entry. Imported actuator and target values are unchanged.
Tested on
The misleading summary was observed on an Elvox Tab 7S Up (40517), SW 2.1.0203 / FW 1.06, cloud TLS. The correction is tested with simulated LAN downloads, cloud downloads and uploaded-file imports; it has not yet been installed on the physical plant.
Docs
Docs: not needed; changes are in the import confirmation text, with English and Italian translations in sync.
Changelog
Changelog: Bug fixes - Phonebook import confirmation displays the correct source and no longer suggests that changing the SGA overwrites an independently configured PICG.
Validation: 2,177 default tests passed (1 skipped), line and branch coverage 95.87%,
ruff check .and Python compilation passed. Regression tests verify independent SGA/PICG values and the source shown for all three import paths. Hardware report: #172.