Repository navigation
feat(options): allow overriding outgoing video from pairing QR - #175
andreacasarin wants to merge 2 commits into
Conversation
|
Thanks @andreacasarin, another clear one. The diagnosis checks out: if
Thanks again for following this up so thoroughly. |
|
LGTM. Default follows the QR, the saved option wins through the |
|
Reviewed: the option reaches One non-blocking nit: Merge order for 1.0.23: #171 → #174 → #173 → #175; I'll merge Generated by Claude Code |
Resolve the conflict in tests/test_config_flow_steps.py by keeping both sides: the outgoing video option tests and the internal panel and import summary tests from ha-vimar#173 and ha-vimar#174. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMtKjPuZNEaX23BpL9AsaA





What and why
On the Tab 7S Up reported in #172, View outside connected with working audio but the card waited indefinitely for video and Home Assistant Stream reported
Stream has no video. The stored QR-derivedvideo_enabledvalue was false, so outgoing offers omitted video. Changing only that stored value to true and restarting restored outdoor video.Expose Enable video in outgoing calls in the Settings options form. Its initial value follows the pairing QR (or true for entries without the field); saved options take precedence through the existing entry setup and reload path. Preserve the existing value when a submission omits the field, and retain the submitted choice when validation fails. Incoming calls still mirror the peer's media offer.
This does not redefine the QR field's meaning or enable video unconditionally on audio-only entrances. The original decoded QR field has not been independently inspected on the reported device.
Related: #172. Independent of the other compatibility follow-up PRs.
Tested on
Elvox Tab 7S Up 40517, SW 2.1.0203, FW 1.06, HW 00-02, cloud TLS, Home Assistant Container: owner verified outdoor video after the equivalent stored-data change; the new options UI has not been deployed on this hardware.
Nine regression cases cover defaults, both override directions, saved SDP offers, preservation of unrelated options and omitted values, and validation-error redisplay. Eight fail against the original options flow; all pass with this change.
Full default suite: 2,185 passed, 1 skipped, 204 deselected; line and branch coverage 95.87%.
ruff check .,compileall, diff whitespace checks and PR changelog validation pass.Docs
Docs: docs/CONFIGURATION.md and docs/CONFIGURATION.it.md; English and Italian UI strings synchronized.
Changelog
Changelog: Enhancements - Enable or disable video in outgoing intercom calls from Settings, including when the pairing QR initially disables it.