Repository navigation
feat: edit backup settings on their own page instead of a dialog - #19
Merged
Merged
Conversation
Contributor
Author
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #18; GitHub retargets this to
developonce that merges.What
save_settingsendpoint are removed.Why
Settings could be edited in two places that behaved differently: the dialog had the good schedule editor, the form had a raw table with comma-separated weekdays. The dialog also kept its own copy of the settings, which went out of sync when it was reopened.
Notes
backup_schedulechild table, now hidden; the editor reads and writes its rows, so saving, validation and change tracking are the form's own.9:00:00) are padded before they go into the time input, which otherwise showed them empty.get_configurationreports only whether each deployment variable is set, never its value, and is System Manager only.Testing
Tests updated for the form, saving and the new endpoint (CI). Checked by hand on a local v16 bench in light and dark theme: toggling days, adding and removing rows, changing a time, saving, the client-side validation message, the storage status, and Backup Control picking up the saved state on return. Not checked on v15 in a browser.