Repository navigation
Conversation
Contributor
Author
|
Superseded: #19 carried this fix and has merged, so this pull request no longer changes anything on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read the System Managers from
Has Roledirectly instead offrappe.utils.user.get_users_with_role.Why
get_users_with_roleleaves out Administrator. On a site where Administrator is the only System Manager, a failure raised no desk notification for anyone. This was found by hand on a local v16 bench after #18 had already merged, so the fix did not make it into that pull request.Administrator still gets no email, as its address is a placeholder on most sites.
Testing
Unit test updated. Checked by hand on a local v16 bench: a simulated failure appears in Administrator's notification panel.