Skip to content

[protocol] Add spi check to protect stack leaks #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esnguyen wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −10
Open

[protocol] Add spi check to protect stack leaks #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions protocol/spi_proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,34 +60,39 @@ static void spi_operation_init(struct spi_operation* op) {

static int spi_operation_execute(struct spi_operation* op,
struct libhoth_device* dev) {
uint8_t response_buf[MAX_SPI_OP_PAYLOAD_BYTES];
size_t response_len;
uint8_t response_buf[MAX_SPI_OP_PAYLOAD_BYTES] = {0};
size_t response_len = 0;

// hexdump(op->buf, op->pos);
int status = libhoth_hostcmd_exec(
dev, HOTH_CMD_BOARD_SPECIFIC_BASE + HOTH_PRV_CMD_HOTH_SPI_OPERATION,
/*version=*/0, op->buf, op->pos, response_buf, sizeof(response_buf),
&response_len);

if (status != 0) {
return status;
}

size_t pos = 0;
for (size_t i = 0; i < op->num_transactions; i++) {
struct spi_operation_transaction* transaction = &op->transactions[i];
if (transaction->miso_dest_buf) {
if (transaction->miso_dest_buf_len > 0) {
if (pos + transaction->miso_dest_buf_len > response_len) {
fprintf(stderr,
"returned SPI operation payload is smaller than expected");
return -1;
}

if (transaction->miso_dest_buf_len > 0) {
if (pos + transaction->miso_dest_buf_len + transaction->skip_miso_nbytes >
response_len) {
fprintf(stderr,
"returned SPI operation payload is smaller than expected");
return -1;
}
if (transaction->miso_dest_buf) {
memcpy(transaction->miso_dest_buf,
&response_buf[pos + transaction->skip_miso_nbytes],
transaction->miso_dest_buf_len);
}
}

pos += transaction->skip_miso_nbytes + transaction->miso_dest_buf_len;
}

return 0;
}

Expand Down
Loading