[protocol] Add spi check to protect stack leaks#222
Open
esnguyen wants to merge 1 commit intogoogle:mainfrom
Open
[protocol] Add spi check to protect stack leaks#222esnguyen wants to merge 1 commit intogoogle:mainfrom
esnguyen wants to merge 1 commit intogoogle:mainfrom
Conversation
In response to a gh issue identifying some memory safety issue, this seeks to fix the bound check of a spi response buffer to prevent potential stack leaks. The spi response buffer adds an additional check to ensure that the total length of the response does not exceed the buffer size. Signed-off-by: Ellis Sarza-Nguyen <sarzanguyen@google.com>
esnguyen
force-pushed
the
esnguyen/spi_leak
branch
from
a1318b7 to
171ba4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to a gh issue identifying some memory safety issue, this seeks to fix the bound check of a spi response buffer to prevent potential stack leaks. The spi response buffer adds an additional check to ensure that the total length of the response does not exceed the buffer size.
Github issue
#221