Skip to content

refactor(filters): adopt Primer checkbox and help popover - #3497

Merged
setchy merged 1 commit into
mainfrom
refactor/primer-filter-help-components
Oct 25, 2026
Merged

setchy merged 1 commit into
mainfrom
refactor/primer-filter-help-components

Conversation

@setchy

@setchy setchy commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Replace the custom Checkbox wrapper with Primer Checkbox and CounterLabel through a shared FilterCheckbox row.
  • Migrate FilterSection and AccountFilter to FilterCheckbox.
  • Delete the unused FieldLabel primitive and its tests/snapshots.
  • Rename the rich custom Tooltip to HelpPopover and move it to components/primitives.
  • Keep Primer AnchoredOverlay for interactive rich content, but use Primer IconButton for the anchor.
  • Keep the help icon accent-coloured and start-align the popover so it stays inside the content pane.
  • Style the popover panel with the design-language radius/shadow tokens and theme-aware border.
  • Leave the deprecated Primer Tooltip usages alone for now.

Why

  • Checkbox was only used by filter multi-select, which maps directly to Primer’s checkbox primitive.
  • FieldLabel had no production consumers after the settings migration.
  • The custom tooltip was not a simple tooltip; it is a click-open popover with icon lists, bullets, and action links. Primer’s deprecated Tooltip is text-only, so the correct Primer path is IconButton + AnchoredOverlay.

Verification

  • pnpm test: 200 files, 1,967 tests passed
  • pnpm exec vp check --no-fmt: 462 files passed
  • scripts/visual.sh filters: 2 baselines passed
  • scripts/visual.sh settings: 9 baselines passed
  • SonarQube Quality Gate: passing (0 issues, 100% new coverage)

@setchy
setchy force-pushed the refactor/settings-controls-primer branch from e5c89aa to f3884ae Compare October 25, 2026 02:33
@setchy
setchy force-pushed the refactor/primer-filter-help-components branch from 018fe5e to 98a08bc Compare October 25, 2026 02:38
@setchy
setchy force-pushed the refactor/primer-filter-help-components branch 2 times, most recently from 1efc2b4 to 9311fa6 Compare October 25, 2026 03:07
Base automatically changed from refactor/settings-controls-primer to main October 25, 2026 03:33
@github-actions github-actions Bot added the refactor Refactoring of existing feature label Oct 25, 2026
@setchy
setchy force-pushed the refactor/primer-filter-help-components branch 2 times, most recently from 4cb92fb to 758eb9d Compare October 25, 2026 09:16
@setchy
setchy marked this pull request as ready for review October 25, 2026 10:02
@setchy
setchy requested a review from afonsojramos as a code owner October 25, 2026 10:02
@setchy
setchy force-pushed the refactor/primer-filter-help-components branch 3 times, most recently from eb2081e to d329fe4 Compare October 25, 2026 11:23
Replace the bespoke filter checkbox and field label with Primer components. Move the rich help tooltip to primitives, anchor it with a Primer IconButton, keep the accent-coloured icon, and use tokenised surface styles so the popover follows the active theme. Start-align the overlay so it opens inside the content pane instead of over the sidebar.
@setchy
setchy force-pushed the refactor/primer-filter-help-components branch from d329fe4 to 92cceb4 Compare October 25, 2026 11:26
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy merged commit 9035425 into main Oct 25, 2026
23 checks passed
@setchy
setchy deleted the refactor/primer-filter-help-components branch October 25, 2026 11:33
@github-actions github-actions Bot added this to the Release 7.11.0 milestone Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactoring of existing feature

Development

Successfully merging this pull request may close these issues.

1 participant