Repository navigation
refactor(filters): adopt Primer checkbox and help popover - #3497
Merged
Merged
Conversation
setchy
force-pushed
the
refactor/settings-controls-primer
branch
from
October 25, 2026 02:33
e5c89aa to
f3884ae
Compare
setchy
force-pushed
the
refactor/primer-filter-help-components
branch
from
October 25, 2026 02:38
018fe5e to
98a08bc
Compare
setchy
force-pushed
the
refactor/primer-filter-help-components
branch
2 times, most recently
from
October 25, 2026 03:07
1efc2b4 to
9311fa6
Compare
setchy
force-pushed
the
refactor/primer-filter-help-components
branch
2 times, most recently
from
October 25, 2026 09:16
4cb92fb to
758eb9d
Compare
setchy
marked this pull request as ready for review
October 25, 2026 10:02
setchy
force-pushed
the
refactor/primer-filter-help-components
branch
3 times, most recently
from
October 25, 2026 11:23
eb2081e to
d329fe4
Compare
Replace the bespoke filter checkbox and field label with Primer components. Move the rich help tooltip to primitives, anchor it with a Primer IconButton, keep the accent-coloured icon, and use tokenised surface styles so the popover follows the active theme. Start-align the overlay so it opens inside the content pane instead of over the sidebar.
setchy
force-pushed
the
refactor/primer-filter-help-components
branch
from
October 25, 2026 11:26
d329fe4 to
92cceb4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Checkboxwrapper with PrimerCheckboxandCounterLabelthrough a sharedFilterCheckboxrow.FilterSectionandAccountFiltertoFilterCheckbox.FieldLabelprimitive and its tests/snapshots.TooltiptoHelpPopoverand move it tocomponents/primitives.AnchoredOverlayfor interactive rich content, but use PrimerIconButtonfor the anchor.Tooltipusages alone for now.Why
Checkboxwas only used by filter multi-select, which maps directly to Primer’s checkbox primitive.FieldLabelhad no production consumers after the settings migration.Tooltipis text-only, so the correct Primer path isIconButton+AnchoredOverlay.Verification
pnpm test: 200 files, 1,967 tests passedpnpm exec vp check --no-fmt: 462 files passedscripts/visual.sh filters: 2 baselines passedscripts/visual.sh settings: 9 baselines passed