Repository navigation
refactor(settings): refresh controls with Primer - #3496
Merged
Merged
Conversation
Add settings control wrappers for compact toggles, segmented choices, selects, custom rows, dividers, and animated dependent reveals. Migrate Appearance, Inbox, Alerts, Tray, and System to the wrappers; restore detailed secondary tooltips; remove the settings-only custom RadioGroup; and keep Checkbox for filter multi-select. Fix the settings footer scroll issue by constraining the contents pane and document overflow. Update snapshots and visual baselines.
setchy
force-pushed
the
refactor/settings-controls-primer
branch
from
October 25, 2026 02:33
e5c89aa to
f3884ae
Compare
Keep label-click behavior with native label buttons that are hidden from assistive technology and removed from the tab order, while the switch or control remains the accessible target. Use a fieldset for settings rows with grouped controls and align the Fetch subheading spacing with the List and GitHub groups. Update tests and visual baselines.
Make segmented choice labels advance to the next option, keep select labels opening the picker, and remove label-click behavior from stepper rows where it does not add value. Normalize label typography across toggles, choices, and rows, and balance the Fetch subheading spacing. Update tests and visual baselines.
Primer's unlayered stylesheet resets fieldset padding and borders, which stripped the divider and vertical padding from stepper rows. Move the settings list rhythm into unlayered CSS and mark the button label typography important so it matches the rows. Drop the subheading divider so the last row of every group, main section or subgroup, is followed by spacing instead of a line. Keep the GNOME extension note outside the row list so it no longer adds a divider after the last Linux setting.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base PR
This is the first PR in the stack and now targets
main.This PR intentionally contains only the settings that exist on
main; the native notification style, actions, keep-visible, and click controls are added by #3491.OpenSpec change:
06-refresh-settings-controls-with-primer.Summary
Screen.Recording.2026-10-24.at.10.27.47.PM.mov
Screen.Recording.2026-10-24.at.10.30.31.PM.mov
SettingsToggle,SettingsChoice,SettingsRow,SettingsList, andSettingsReveal.Banner.RadioGroup; keepCheckboxfor filter multi-select.min-h-0on the contents scroll paneVerification
pnpm test: 201 files, 1,974 tests passedpnpm exec vp check --no-fmt: 464 files passedscripts/visual.sh settings: 9 baselines passedScope notes
min-h-0/overflow fix is a shared layout fix, exposed by the taller settings content.