Skip to content

refactor(settings): split inbox and alert sections #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 3 commits into from
Oct 24, 2026
Merged

refactor(settings): split inbox and alert sections #3492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c37be9a
refactor(settings): split inbox and alert sections
setchy Oct 24, 2026
8c955d1
refactor(settings): refine inbox and alert organization
setchy Oct 24, 2026
aa4776d
refactor(settings): polish section headings and group labels
setchy Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/renderer/components/fields/RadioGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,13 @@ export interface RadioGroupProps {
}

export function RadioGroup(props: Readonly<RadioGroupProps>) {
const firstOptionId = props.options[0]
? `radio-${props.name}-${props.options[0].value.toLowerCase()}`
: props.name;

return (
<Stack align="center" className="text-sm" direction="horizontal" gap="condensed">
<FieldLabel label={props.label} name={props.name} />
<FieldLabel label={props.label} name={firstOptionId} />

{props.options.map((item) => {
const name = `radio-${props.name}-${item.value.toLowerCase()}`;
Expand Down
4 changes: 2 additions & 2 deletions src/renderer/components/fields/__snapshots__/RadioGroup.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions src/renderer/components/filters/AccountFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { useNotifications } from '../../hooks/useNotifications';
import { useAccountsStore, useFiltersStore } from '../../stores';

import { Checkbox } from '../fields/Checkbox';
import { Title } from '../primitives/Title';
import { SectionHeading } from '../primitives/SectionHeading';

import { getAccountUUID } from '../../utils/auth/utils';

Expand All @@ -17,9 +17,13 @@ export function AccountFilter() {

return (
<fieldset id="filter-accounts">
<Title icon={PersonIcon} tooltip={<Text>Filter notifications by account.</Text>}>
<SectionHeading
as="legend"
icon={PersonIcon}
tooltip={<Text>Filter notifications by account.</Text>}
>
Account
</Title>
</SectionHeading>

<Stack direction="vertical" gap="condensed">
{accounts.map((account) => {
Expand Down
7 changes: 4 additions & 3 deletions src/renderer/components/filters/FilterSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { useNotifications } from '../../hooks/useNotifications';
import { type FiltersState, useFiltersStore, useSettingsStore } from '../../stores';

import { Checkbox } from '../fields/Checkbox';
import { Title } from '../primitives/Title';
import { SectionHeading } from '../primitives/SectionHeading';

import type { Filter } from '../../utils/notifications/filters';
import { RequiresDetailedNotificationWarning } from './RequiresDetailedNotificationsWarning';
Expand Down Expand Up @@ -50,7 +50,8 @@ function FilterSectionComponent<K extends keyof FiltersState>({

return (
<fieldset id={id}>
<Title
<SectionHeading
as="legend"
icon={icon}
tooltip={
tooltip && (
Expand All @@ -62,7 +63,7 @@ function FilterSectionComponent<K extends keyof FiltersState>({
}
>
{title}
</Title>
</SectionHeading>

<Stack direction={layout} gap={layout === 'horizontal' ? 'normal' : 'condensed'}>
{(Object.keys(filter.FILTER_TYPES) as FiltersState[K][number][])
Expand Down
7 changes: 4 additions & 3 deletions src/renderer/components/filters/SearchFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { cn } from 'cn';

import { useFiltersStore, useSettingsStore } from '../../stores';

import { Title } from '../primitives/Title';
import { SectionHeading } from '../primitives/SectionHeading';

import { IconColor, type SearchToken, Size } from '../../types';

Expand Down Expand Up @@ -66,7 +66,8 @@ export function SearchFilter() {

return (
<fieldset>
<Title
<SectionHeading
as="legend"
icon={SearchIcon}
tooltip={
<Stack direction="vertical" gap="condensed">
Expand Down Expand Up @@ -109,7 +110,7 @@ export function SearchFilter() {
}
>
Search
</Title>
</SectionHeading>

<Stack direction="vertical" gap="condensed">
<TokenSearchInput
Expand Down
154 changes: 80 additions & 74 deletions src/renderer/components/filters/__snapshots__/FilterSection.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading