Repository navigation
refactor(settings): split inbox and alert sections - #3492
Merged
Merged
Conversation
Rename the Notifications section to Inbox and add an Alerts section for notification delivery. Move the existing show-notifications, sound, and volume controls out of System, and clarify the external-link focus label. No setting keys or persisted values change.
Move notification-list display settings from Appearance to Inbox, and move update notifications from System to Alerts. Add Fetching, List, and GitHub subheadings inside Inbox. Hide GitHub-only controls when no GitHub account is connected, and disable mark-as-done with a reason when the connected GitHub account does not support it. Tighten the remaining setting labels. Persisted setting keys and values are unchanged.
Rename the Title primitive to SectionHeading and make the heading vs fieldset legend semantics explicit. Use a hidden legend plus a visible heading for fieldsets so icons and labels stay on one line. Extract SettingsGroupHeading and add Download, ListUnordered, and MarkGithub icons to the Inbox groups. Refresh the update-notification, startup, and window labels. Update unit, route, and visual baselines.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Titleprimitive toSectionHeading, with correct fieldset legend vs heading semantics. ExtractSettingsGroupHeadingfor Inbox groups.Appearance,Inbox,Alerts,Tray,System,Reset.This is a behavior-neutral information-architecture change. No setting keys, defaults, or persisted values change.
Stack
This PR is the base for the native notification work in #3491. After this merges, #3491 will be retargeted to
mainand will add the native style, actions, keep-visible, and notification-click controls to the Alerts section.Reviewer notes
SectionHeading, andSettingsGroupHeading.Fetch read and done notificationsandFetch all notificationsremain visible for all accounts. They are cross-forge settings; only their capability semantics vary by forge.Verification
pnpm test: 197 files, 1943 tests passedpnpm exec vp check --no-fmt: 456 files passedManual checks