Repository navigation
fix(repo): close the small P28 review follow-ons - #203
Conversation
refs::write_head and delete_branch now validate the branch name; SC_PACK_CHUNK is clamped to MAX_OBJECT_SIZE instead of producing frames every receiver refuses; Repo::worktree_paths is a paths-only walk (list_worktree_paths) rather than reading every file; and the /-boundary prefix rule is one shared protect::path_under_prefix used by rule lookup and the sc protect nudge. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 7
✨ Finishing Touches
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18108d9244
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex: a chunk frame is the ST_PACK_CHUNK tag byte plus the data, so data at MAX_OBJECT_SIZE made a frame one byte over what the receiver accepts. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tonibergholm-codento
left a comment
There was a problem hiding this comment.
Required checks green on 6eb752c; Codex finding fixed and resolved.
Four small non-blocking items from the P28 security-sweep final review, still on the Deferred list:
refs::write_headandrefs::delete_branchnow runvalidate_branch_namelike every other ref write (delete_branchjoins its argument onto the refs directory, so a crafted name must never reach outside it).SC_PACK_CHUNKis clamped toMAX_OBJECT_SIZE: a larger value made every transfer fail with a confusing receiver-side error (a frame above the length cap). The decision is a purechunk_fromso it is testable without touching the environment.Repo::worktree_paths(used by thesc protectnudge) no longer reads every file's bytes:worktree::list_worktree_pathsis the same walk with the same.scignoreand tracked-path rules, minus the read./-boundary prefix rule was written twice (protect::matching_prefixandrun_protect's nudge); it is now oneprotect::path_under_prefix.Verification
New tests:
write_head_and_delete_branch_validate_the_branch_name,chunk_from_defaults_and_clamps_to_the_object_cap,list_worktree_paths_matches_read_worktree(same list asread_worktree, ignore rules and the tracked-under-ignored exemption),path_under_prefix_matches_at_a_boundary_only.cargo fmt,cargo clippy --workspace --all-targets -D warnings,cargo test --workspacepass. ROADMAP entry marked shipped.🤖 Generated with Claude Code
Summary by CodeRabbit
HEADupdates.