Skip to content

Small follow-ups from the 2026-10 review rounds (tests, stale comments, rustdoc) #219

Closed

Description

@tonibergholm

Non-blocking items raised in reviews of #203 to #208 that were left out of those PRs. Each is small; do them together or split.

Tests

Comments and docs

  • crates/repo/src/wire.rs (around the TempServeDir contract) and crates/cli/src/main.rs (around the --store serve home) say the handler gates on .sc "unconditionally (404 before any dispatch)". Since fix(repo): answer 401 before 404 on a mandatory-auth listener #207 the 404 follows the auth gate; reword.
  • cargo doc --workspace --no-deps warns that public docs for timeout_secs, serve_http and serve_http_listener link to private items (handle_http_connection, bind_is_allowed, AcceptBackoff). Use plain code spans.

Code

  • ScHttpUrl::parse splits on the first :, so an IPv6 literal host (sc+http://[::1]:7777/repo) is rejected. Handle bracketed hosts, with tests for parse and sc remote add.
  • Optional: replace the eight too_many_arguments functions (snapshot_files has 12 parameters) with parameter structs and drop the last workspace clippy allow. Only if it reads better than the long lists.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentTriage: ready for an agent to pick up

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions