You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Small follow-ups from the 2026-10 review rounds (tests, stale comments, rustdoc) #219
Non-blocking items raised in reviews of #203 to #208 that were left out of those PRs. Each is small; do them together or split.
Tests
Theirs-side resolve carry (feat(repo): carry their ciphertext when a protected conflict resolves --theirs #205): add a sc rebase --continue case, a convergent (pre-P33) blob on their side, and the fallback to sealing when their wrap list is missing from the merged protection. Also an sc grant on our side after the fork, resolved --theirs, asserting the documented under-grant.
crates/repo/src/wire.rs (around the TempServeDir contract) and crates/cli/src/main.rs (around the --store serve home) say the handler gates on .sc "unconditionally (404 before any dispatch)". Since fix(repo): answer 401 before 404 on a mandatory-auth listener #207 the 404 follows the auth gate; reword.
cargo doc --workspace --no-deps warns that public docs for timeout_secs, serve_http and serve_http_listener link to private items (handle_http_connection, bind_is_allowed, AcceptBackoff). Use plain code spans.
Code
ScHttpUrl::parse splits on the first :, so an IPv6 literal host (sc+http://[::1]:7777/repo) is rejected. Handle bracketed hosts, with tests for parse and sc remote add.
Optional: replace the eight too_many_arguments functions (snapshot_files has 12 parameters) with parameter structs and drop the last workspace clippy allow. Only if it reads better than the long lists.
Activity
fix(repo,cli): canonical IPv6 pin keys, accurate gate wording, IPv6 p…
fix(repo): read pin-file keys with the URL authority grammar (#219)
chore: review follow-ups, IPv6 sc+http hosts, pin-file parsing (#222)