Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions fork/helm-e2e-dumps-restarted-containers-end.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ status: carried
commits:
- 'ci: dump a restarted container''s end in helm-e2e diagnostics'
upstream:
outcome: to-file
refs: []
exit: 'the dump pull request merged, then the Substrate re-pin drops the commit; fork-only fallback on the same date as kagent-dev/substrate#71'
outcome: open
refs: [kagent-dev/substrate#71]
exit: 'kagent-dev/substrate#71 merged with the dump commit, then the Substrate re-pin drops the commit; no review by 2026-11-17 makes it fork-only fork infrastructure with #71 kept as the exit'
class: 5
destination: 'kagent-dev/substrate helm-e2e.yaml, the Dump diagnostics on failure step (lines 156-163 at 6383ea118)'
first_step: 'open a pull request on kagent-dev/substrate from the source branch once kagent-dev/substrate#71 merges'
source: 'upstream/helm-e2e-dump-previous@11bfb4132 (on 6383ea118, +10; reads each restarted container''s previous log by name, where the line''s commit probes --all-containers)'
destination: 'kagent-dev/substrate#71, as its second commit (same workflow and job as the lanes change)'
first_step: 'the comment on kagent-dev/substrate#71 asking a maintainer to approve its workflow runs and review it'
source: 'upstream/helm-e2e-independent-lanes@51a66afaf, a cherry-pick of upstream/helm-e2e-dump-previous@11bfb4132 (+10; reads each restarted container''s previous log by name, where the line''s commit probes --all-containers)'
test: 'restart an ate-system container mid-suite and fail a lane: the dump prints its termination reason, exit code and previous log, and the Warning events'
recheck: 2026-11-17
owner: unassigned
owner: teemow
draft: issuecomment-6301363794
decision: issuecomment-6301358702
depends_on: [helm-e2e-lanes-run-whatever-an-earlier-lane-did]
verified: 2026-10-20
depends_on: []
verified: 2026-10-23
---
# helm-e2e's failure dump names a restarted container's end

Expand All @@ -39,3 +39,5 @@ to file: kagent-dev/substrate's helm-e2e carries the same dump step; agent-subst
[#362](https://github.com/giantswarm/substrate/pull/362)

2026-10-20: placed by the T16 ci-publish-infra theme review (the decision comment is `upstream.decision` on the theme issue): upstream PR on kagent-dev/substrate after #71.

2026-10-23: folded into kagent-dev/substrate#71 as its second commit (cherry-pick of `11bfb4132`) instead of a pull request of its own after #71; same workflow, same job.
8 changes: 5 additions & 3 deletions fork/helm-e2e-lanes-run-whatever-an-earlier-lane-did.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ upstream:
refs: [kagent-dev/substrate#71]
exit: 'kagent-dev/substrate#71 merged, then the Substrate re-pin drops the commit; no review by 2026-11-17 makes it fork-only fork infrastructure with #71 kept as the exit'
class: 5
destination: 'kagent-dev/substrate#71'
destination: 'kagent-dev/substrate#71, which also carries helm-e2e-dumps-restarted-containers-end'
first_step: 'comment on kagent-dev/substrate#71 asking a maintainer to approve its workflow runs (action_required) and to review it'
source: 'upstream/helm-e2e-independent-lanes@90931ad3c (+7, merges cleanly on kagent-dev/substrate main 6383ea118)'
source: 'upstream/helm-e2e-independent-lanes@51a66afaf (90931ad3c +7, then the dump commit +10; merges cleanly on kagent-dev/substrate main)'
test: 'make the gVisor lane fail: the later lanes still run and the step that requires every lane reports the failed one'
recheck: 2026-11-17
owner: teemow
draft: issuecomment-6301363233
decision: issuecomment-6301358702
depends_on: []
verified: 2026-10-20
verified: 2026-10-23
---
# helm-e2e's lanes each run, whatever an earlier lane did

Expand All @@ -39,3 +39,5 @@ The lanes are steps of one job, so a failed lane skipped every later one: a flak
[#366](https://github.com/giantswarm/substrate/pull/366)

2026-10-20: placed by the T16 ci-publish-infra theme review (the decision comment is `upstream.decision` on the theme issue): upstream PR kagent-dev/substrate#71, unreviewed since 2026-10-13.

2026-10-23: kagent-dev/substrate#71 also carries the restarted-container dump (helm-e2e-dumps-restarted-containers-end) as its second commit, so both changes share one review.
18 changes: 10 additions & 8 deletions fork/helm-e2e-pins-azure-setup-helm-v4.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ status: carried
commits:
- 'ci: pin setup-helm and the Helm version in helm-e2e'
upstream:
outcome: to-file
refs: [kagent-dev/substrate#86]
exit: 'the Helm version pull request merged; the Substrate re-pin onto a kagent-dev/substrate commit carrying it drops the commit'
outcome: open
refs: [kagent-dev/substrate#86, kagent-dev/substrate#96]
exit: 'kagent-dev/substrate#96 merged; the Substrate re-pin onto a kagent-dev/substrate commit carrying it drops the commit'
class: 5
destination: 'kagent-dev/substrate helm-e2e.yaml and helm-verify.yaml: a version input on azure/setup-helm; the SHA pin half is upstream since kagent-dev/substrate#86 (9d1968a9)'
first_step: 'open a pull request on kagent-dev/substrate from the source branch'
source: 'upstream/helm-version-pin@fd43d8446 (on kagent-dev/substrate main 6383ea118, +4); upstream/helm-e2e-pin-setup-helm@5b47d3578 is retired (it conflicts with #86)'
destination: 'kagent-dev/substrate#96 (version input on azure/setup-helm in helm-e2e.yaml and helm-verify.yaml); the SHA pin half is upstream since kagent-dev/substrate#86 (9d1968a9)'
first_step: 'a maintainer reviews kagent-dev/substrate#96 and approves its workflow runs'
source: 'upstream/helm-version-pin@fd43d8446 (+4, merges cleanly on kagent-dev/substrate main); upstream/helm-e2e-pin-setup-helm@5b47d3578 is retired (it conflicts with #86)'
test: 'the helm-e2e and helm-verify logs show Helm v4.3.1; azure/setup-helm v4.3.1 without a version falls back to v3.18.4 when its latest-version lookup fails (src/run.ts:13,49-59)'
recheck: '2026-11-17, then each Substrate re-pin'
owner: unassigned
owner: QuentinBisson
draft: issuecomment-6301362157
decision: issuecomment-6301358702
couplings: [compat-migrations]
depends_on: []
verified: 2026-10-20
verified: 2026-10-23
---
# helm-e2e pins `azure/setup-helm` to its v4.3.1 release by commit and installs Helm v4.3.0 on every …

Expand All @@ -40,3 +40,5 @@ to file: the upstream-shaped patch is branch [`upstream/helm-e2e-pin-setup-helm`
[#275](https://github.com/giantswarm/substrate/pull/275): `git cherry-pick -x` of `5b47d357`, adapted to the line's indentation

2026-10-20: placed by the T16 ci-publish-infra theme review (the decision comment is `upstream.decision` on the theme issue): the SHA pin is upstream (kagent-dev/substrate#86, `9d1968a9`); the Helm version goes upstream as its own pull request; the commit rides the Substrate conversion re-pin of the compat-migrations theme.

2026-10-23: opened as kagent-dev/substrate#96, ready for review, from `upstream/helm-version-pin` (`fd43d844`); Helm v4.3.1 is still the latest Helm 4 release.
18 changes: 10 additions & 8 deletions fork/helm-verify-pins-actions-checkout-v5-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ status: carried
commits:
- 'ci: pin checkout, setup-helm and the Helm version in helm-verify'
upstream:
outcome: to-file
refs: [kagent-dev/substrate#86]
exit: 'the Helm version and checkout pull requests merged, then the Substrate re-pin drops the commit; a declined checkout pull request makes that half fork-only, with no functional effect'
outcome: open
refs: [kagent-dev/substrate#86, kagent-dev/substrate#96]
exit: 'kagent-dev/substrate#96 merged takes the Helm version; the actions/checkout v5.1.0 half stays fork-only with no functional effect (not proposed: it would reverse the v4.4.0 pin #86 chose); the re-pin onto a commit carrying #96 shrinks the commit to that checkout bump'
class: 5
destination: 'kagent-dev/substrate helm-verify.yaml:30-31: the Helm version with the helm-e2e row, actions/checkout v5.1.0 as its own lower-priority pull request; the SHA pins are upstream since #86'
first_step: 'open the checkout pull request on kagent-dev/substrate after the Helm version pull request'
source: 'upstream/helm-verify-checkout-v5@df92b6a48 (on 6383ea118, +1/-1); the Helm version is upstream/helm-version-pin@fd43d8446; upstream/helm-verify-pin-setup-helm@96c6557e0 is retired'
destination: 'kagent-dev/substrate#96 for the Helm version in helm-verify.yaml; the SHA pins are upstream since #86; actions/checkout v5.1.0 is fork-only'
first_step: 'a maintainer reviews kagent-dev/substrate#96 and approves its workflow runs'
source: 'upstream/helm-version-pin@fd43d8446 for the Helm version; upstream/helm-verify-checkout-v5@df92b6a48 is retired (checkout half not proposed); upstream/helm-verify-pin-setup-helm@96c6557e0 is retired'
test: 'helm lint and hack/render-manifests.sh --check pass in helm-verify on Helm v4.3.1 with actions/checkout v5.1.0'
recheck: 'each Substrate re-pin'
owner: unassigned
owner: QuentinBisson
draft: issuecomment-6301362710
decision: issuecomment-6301358702
couplings: [compat-migrations]
depends_on: [helm-e2e-pins-azure-setup-helm-v4]
verified: 2026-10-20
verified: 2026-10-23
---
# helm-verify pins `actions/checkout` to its v5.1.0 release and `azure/setup-helm` to its v4.3.1 …

Expand All @@ -40,3 +40,5 @@ to file: the upstream-shaped patch is branch [`upstream/helm-verify-pin-setup-he
[#299](https://github.com/giantswarm/substrate/pull/299): `git cherry-pick -x` of `96c6557e`

2026-10-20: placed by the T16 ci-publish-infra theme review (the decision comment is `upstream.decision` on the theme issue): SHA pins upstream (kagent-dev/substrate#86); upstream's helm-verify runs `hack/render-manifests.sh --check` where the line still runs `make verify-helm-template`.

2026-10-23: the Helm version rides kagent-dev/substrate#96. The actions/checkout v5.1.0 half is not proposed upstream: it would reverse the v4.4.0 pin kagent-dev/substrate#86 chose on 2026-10-20 and changes nothing functionally, so it stays fork-only.
Loading