feat(core): Accept CollectBehavior shorthand for dataCollection.httpHeaders - #24336
Merged
Conversation
…tpHeaders`
The docs and the v10.57 changelog advertise `httpHeaders: { deny: [...] }`,
but the resolver only understood the `{ request, response }` shape, so a
shorthand silently fell through to the defaults. Normalize a boolean or
allow/deny object into both directions while keeping `{}` and directional
objects on the existing merge path.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b4af1ad. Configure here.
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Sep 11, 2026
chargome
added a commit
that referenced
this pull request
Sep 11, 2026
…n.httpHeaders` (#24339) Backport of: #24336 ## Differences to the original PR - `packages/core/src/index.ts`: dropped the `HttpHeadersCollection` type export. v10 does not export any of the `datacollection` types (`CollectBehavior`, `DataCollection`, ...) from the core index, so there was no export list to add it to. - `packages/core/src/utils/data-collection/resolveDataCollectionOptions.ts`: `resolveHttpHeaders` takes the resolved `base` instead of reading `DEFAULTS` directly. v10 still has the `sendDefaultPii` bridge, so omitted directions must fall back to whichever base is in effect, matching the surrounding code. - `packages/core/src/types/datacollection.ts`: `ResolvedDataCollection` omits `'queryParams' | 'httpHeaders'`. v10 already omitted the deprecated `queryParams` key, and the accompanying `todo(v11)` comment was updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataCollection.httpHeadersis documented as acceptingtrue,false,{ allow }or{ deny }, but the resolver only understood{ request, response }, so a shorthand was silently ignored and both directions fell back totrue.The resolver now applies a
CollectBehaviorshorthand to both directions, while{}and directional objects keep the existing per-direction merge.Fixes #24335