feat(v10/core): Accept CollectBehavior shorthand for dataCollection.httpHeaders - #24339
Merged
Conversation
…n.httpHeaders` Backport of: #24336
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #24336
Differences to the original PR
packages/core/src/index.ts: dropped theHttpHeadersCollectiontype export. v10 does not export any of thedatacollectiontypes (CollectBehavior,DataCollection, ...) from the core index, so there was no export list to add it to.packages/core/src/utils/data-collection/resolveDataCollectionOptions.ts:resolveHttpHeaderstakes the resolvedbaseinstead of readingDEFAULTSdirectly. v10 still has thesendDefaultPiibridge, so omitted directions must fall back to whichever base is in effect, matching the surrounding code.packages/core/src/types/datacollection.ts:ResolvedDataCollectionomits'queryParams' | 'httpHeaders'. v10 already omitted the deprecatedqueryParamskey, and the accompanyingtodo(v11)comment was updated to match.