Skip to content

test(e2e): Fix node-firebase span name expectations for span streaming #24225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 1 commit into from
Sep 9, 2026
Merged

test(e2e): Fix node-firebase span name expectations for span streaming #24225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions dev-packages/e2e-tests/test-applications/node-firebase/tests/functions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
test('should create one segment for an HTTP function', async () => {
const spansPromise = collectStreamedSpansUntilSegment(
'node-firebase',
span => span.name === 'firebase.function.http.request' && span.attributes['faas.name']?.value === 'helloWorld',
span => span.name === 'helloWorld' && span.attributes['faas.name']?.value === 'helloWorld',
);

const response = await fetch('http://localhost:5001/demo-functions/default/helloWorld');
Expand All @@ -20,7 +20,7 @@ test('should create one segment for an HTTP function', async () => {
const span = spans[0]!;
expect(getSpanOp(span)).toBe('function.gcp');
expect(span).toMatchObject({
name: 'firebase.function.http.request',
name: 'helloWorld',
status: 'ok',
span_id: expect.any(String),
trace_id: expect.any(String),
Expand All @@ -29,6 +29,7 @@ test('should create one segment for an HTTP function', async () => {
'faas.name': { value: 'helloWorld', type: 'string' },
'faas.provider': { value: 'firebase', type: 'string' },
'faas.trigger': { value: 'http.request', type: 'string' },
'gcp.function.context.type': { value: 'firebase.function.http.request', type: 'string' },
'sentry.kind': { value: 'server', type: 'string' },
'sentry.origin': { value: 'auto.firebase.functions', type: 'string' },
'sentry.sample_rate': { value: expect.any(Number), type: 'integer' },
Expand All @@ -45,9 +46,7 @@ test('should send failed span when the function fails', async () => {
const spanPromise = waitForStreamedSpan(
'node-firebase',
span =>
span.is_segment &&
span.name === 'firebase.function.http.request' &&
span.attributes['faas.name']?.value === 'unhandeledError',
span.is_segment && span.name === 'unhandeledError' && span.attributes['faas.name']?.value === 'unhandeledError',
);

await fetch('http://localhost:5001/demo-functions/default/unhandeledError');
Expand Down Expand Up @@ -85,7 +84,7 @@ test('should create a document and trigger onDocumentCreated and another with au
expect(spans).toHaveLength(1);
const segment = spans[0]!;
expect(segment).toMatchObject({
name: `firebase.function.${trigger}`,
name,
status: 'ok',
span_id: expect.any(String),
trace_id: expect.any(String),
Expand All @@ -94,6 +93,7 @@ test('should create a document and trigger onDocumentCreated and another with au
'faas.name': { value: name, type: 'string' },
'faas.provider': { value: 'firebase', type: 'string' },
'faas.trigger': { value: trigger, type: 'string' },
'gcp.function.context.type': { value: `firebase.function.${trigger}`, type: 'string' },
'sentry.kind': { value: 'server', type: 'string' },
'sentry.op': { value: 'function.gcp', type: 'string' },
'sentry.origin': { value: 'auto.firebase.functions', type: 'string' },
Expand Down
Loading