test(e2e): Fix node-firebase span name expectations for span streaming - #24225
Merged
Conversation
#24069 made `function.gcp` span names low cardinality: with span streaming enabled (the v11 default), a firebase function span is named after the function itself rather than after `firebase.function.<trigger>`, which moved to the `gcp.function.context.type` attribute. The unit tests were updated in that PR but this E2E app was not, so the required `E2E node-firebase` check has been red on develop ever since. Expect the function name as the span name and assert the new attribute, so the app also covers the static -> streaming description migration. Refs #24069 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
marked this pull request as ready for review
September 9, 2026 09:03
Lms24
requested review from
a team,
logaretm and
stephanie-anderson
and removed request for
a team
September 9, 2026 09:04
chargome
approved these changes
Sep 9, 2026
Lms24
requested review from
msonnb
and removed request for
stephanie-anderson
September 9, 2026 09:04
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#24069 made firebase
function.gcpspan names low cardinality but only updated the unit tests because the E2E tests were skipped. Meanwhile, we also unskipped the E2E tests in #24164, causing the test to fail. Yet another reason for merge queues.firebase.function.<trigger>— expectations updated accordingly.gcp.function.context.typeattribute, which now carries the old name and drives the span description.Refs #24069