Skip to content

test(e2e): Use collectStreamedSpansUntilSegment in the create-remix-app-v2 db specs #24092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreiborza merged 1 commit into from
Sep 4, 2026
Merged

test(e2e): Use collectStreamedSpansUntilSegment in the create-remix-app-v2 db specs #24092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions dev-packages/e2e-tests/test-applications/create-remix-app-v2/tests/db.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
import { expect, test } from '@playwright/test';
import type { SerializedStreamedSpan } from '@sentry-internal/test-utils';
import { collectStreamedSpans, getSpanOp } from '@sentry-internal/test-utils';
import { collectStreamedSpansUntilSegment, getSpanOp } from '@sentry-internal/test-utils';

function isSegmentFor(path: string): (span: SerializedStreamedSpan) => boolean {
return span => getSpanOp(span) === 'http.server' && span.is_segment && span.attributes['url.path']?.value === path;
return span => getSpanOp(span) === 'http.server' && span.attributes['url.path']?.value === path;
}

// Orchestrion force-bundles + transforms mysql/ioredis at build time, and the databases
// are booted via docker-compose in the Playwright global setup.
test.describe('orchestrion DB instrumentation', () => {
test('Instruments ioredis automatically via orchestrion', async ({ baseURL }) => {
const spansPromise = collectStreamedSpans(
'create-remix-app-v2',
spans =>
spans.some(isSegmentFor('/db-ioredis')) && spans.filter(span => getSpanOp(span) === 'db.query').length >= 2,
);
const spansPromise = collectStreamedSpansUntilSegment('create-remix-app-v2', isSegmentFor('/db-ioredis'));

await fetch(`${baseURL}/db-ioredis`);

Expand Down Expand Up @@ -48,10 +44,7 @@ test.describe('orchestrion DB instrumentation', () => {
});

test('Instruments mysql automatically via orchestrion', async ({ baseURL }) => {
const spansPromise = collectStreamedSpans(
'create-remix-app-v2',
spans => spans.some(isSegmentFor('/db-mysql')) && spans.filter(span => getSpanOp(span) === 'db').length >= 2,
);
const spansPromise = collectStreamedSpansUntilSegment('create-remix-app-v2', isSegmentFor('/db-mysql'));

await fetch(`${baseURL}/db-mysql`);

Expand Down
Loading