test(e2e): Use collectStreamedSpansUntilSegment in the create-remix-app-v2 db specs - #24092
Merged
Merged
Conversation
…-app-v2 db specs The segment span ends last, so waiting for it is enough; the explicit child-span count was redundant.
Contributor
size-limit report 📦
|
andreiborza
marked this pull request as ready for review
September 4, 2026 13:02
chargome
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches the two
create-remix-app-v2db specs to the sharedcollectStreamedSpansUntilSegmenthelper from #24073. The explicit child-span count was redundant: the segment span ends last, so its children are already in hand once it arrives.Why
Follow-up to #24058, which landed before the helper existed.
Ref: #23807