Skip to content

feat(i18n): add Persian (fa) locale - #1642

Open
danialshirali16 wants to merge 1 commit into
getopenscreen:mainfrom
danialshirali16:feat/persian-locale
Open

danialshirali16 wants to merge 1 commit into
getopenscreen:mainfrom
danialshirali16:feat/persian-locale

Conversation

@danialshirali16

@danialshirali16 danialshirali16 commented Nov 21, 2026 •

Copy link
Copy Markdown

Summary

Add fa (فارسی) to the desktop app. This covers all 1,223 strings in the seven existing namespaces, including the recording bar, editor, timeline, keyboard shortcuts, and native dialogs.

  • Register Persian in the renderer, Electron main process, and both packaging language lists.
  • Preserve interpolation variables and keep mixed-direction timeline hints and format names readable.
  • Add a regression test for selecting Persian in the main process and resolving its native menu and dialog strings.

The Persian copy was prepared with AI assistance. Feedback from Persian-speaking reviewers is welcome.

Type of change

  • Feature

Release impact

  • Minor

Desktop impact

  • Installer / packaging
  • Not platform-specific

Testing

  • npm run i18n:check and Biome on the changed files
  • TypeScript checks for app and test code
  • npm run test on macOS (5,792 passed, 8 skipped)
  • Browser-mode smoke test on macOS. Checked the fa-IR language suggestion, switching between Persian and English, persistence after reload, the recording bar, editor, keyboard shortcuts, and source picker.

Summary by CodeRabbit

  • New Features
    • Added Persian language support across the app, including settings, recording, editing, timelines, shortcuts, and dialogs.
    • Persian is now included in the supported languages for the app and Microsoft Store.
  • Documentation
    • Updated the supported-language information to include Persian.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds Persian translation files, includes Persian in application locale handling, and updates packaged language lists and supported-language documentation. Tests cover Persian Electron menu and dialog messages and tutorial help translations.

Changes: Persian locale support

Layer / File(s) Summary
Add Persian translations
src/i18n/config.ts, src/i18n/locales/fa/*, src/i18n/__tests__/tutorialHelpTranslations.test.ts
Adds Persian translations for application interface areas and adds Persian to the supported-locale list. The tutorial translation test includes Persian dialogs.
Register Persian in Electron
electron/i18n.ts, electron/i18n.test.ts
Registers Persian common and dialog translations, accepts fa as a main locale, and tests Persian menu and dialog messages.
Update language lists and documentation
electron-builder.json5, README.md, AGENTS.md
Adds Persian to Electron and Microsoft Store language lists and the README supported-language list. Updates the documented locale count from 16 to 18.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: Minimal · up to 7accb

This adds Persian as a selectable language across the app and its installers, with tests for the native menu and dialog strings. No actionable merge-blocking risk was found; Persian wording and right-to-left layout are best confirmed by a native-speaker check.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "feat(i18n): add Persian (fa) locale" names the main change: adding the Persian (fa) locale. The raw summary shows registration in config, i18n.ts, electron-builder, and new fa locale JSON f…
Description check Passed The description follows the template's main sections. It has a Summary, a Type of change (Feature checked), Release impact (Minor checked), Desktop impact (Installer / packaging and Not platform-speci…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat(i18n): add Persian (fa) locale" names the main change: adding the Persian (fa) locale. The raw summary shows registration in config, i18n.ts, electron-builder, and new fa locale JSON files, which all match the title.

Full details: Description check

Explanation

The description follows the template's main sections. It has a Summary, a Type of change (Feature checked), Release impact (Minor checked), Desktop impact (Installer / packaging and Not platform-specific checked), and Testing with commands and results. The Related issue section is missing: it still reads 'Fixes #' with no issue number. The Screenshots / video section is also absent, though the change is a UI locale addition and the author did not add screenshots. The description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 02bda6d8-53e6-494f-b696-6440724c2706
Commits

Reviewing files that changed from the base of the PR and between 00a0d96 and 7accb97.

Files selected for processing: 14

  • AGENTS.md
  • README.md
  • electron-builder.json5
  • electron/i18n.test.ts
  • electron/i18n.ts
  • src/i18n/__tests__/tutorialHelpTranslations.test.ts
  • src/i18n/config.ts
  • src/i18n/locales/fa/common.json
  • src/i18n/locales/fa/dialogs.json
  • src/i18n/locales/fa/editor.json
  • src/i18n/locales/fa/launch.json
  • src/i18n/locales/fa/settings.json
  • src/i18n/locales/fa/shortcuts.json
  • src/i18n/locales/fa/timeline.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant