You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add fa (فارسی) to the desktop app. This covers all 1,223 strings in the seven existing namespaces, including the recording bar, editor, timeline, keyboard shortcuts, and native dialogs.
Register Persian in the renderer, Electron main process, and both packaging language lists.
Preserve interpolation variables and keep mixed-direction timeline hints and format names readable.
Add a regression test for selecting Persian in the main process and resolving its native menu and dialog strings.
The Persian copy was prepared with AI assistance. Feedback from Persian-speaking reviewers is welcome.
Type of change
Feature
Release impact
Minor
Desktop impact
Installer / packaging
Not platform-specific
Testing
npm run i18n:check and Biome on the changed files
TypeScript checks for app and test code
npm run test on macOS (5,792 passed, 8 skipped)
Browser-mode smoke test on macOS. Checked the fa-IR language suggestion, switching between Persian and English, persistence after reload, the recording bar, editor, keyboard shortcuts, and source picker.
Summary by CodeRabbit
New Features
Added Persian language support across the app, including settings, recording, editing, timelines, shortcuts, and dialogs.
Persian is now included in the supported languages for the app and Microsoft Store.
Documentation
Updated the supported-language information to include Persian.
No actionable comments were generated in the recent review.
Walkthrough
The change adds Persian translation files, includes Persian in application locale handling, and updates packaged language lists and supported-language documentation. Tests cover Persian Electron menu and dialog messages and tutorial help translations.
Changes: Persian locale support
Layer / File(s)
Summary
Add Persian translations src/i18n/config.ts, src/i18n/locales/fa/*, src/i18n/__tests__/tutorialHelpTranslations.test.ts
Adds Persian translations for application interface areas and adds Persian to the supported-locale list. The tutorial translation test includes Persian dialogs.
Register Persian in Electron electron/i18n.ts, electron/i18n.test.ts
Registers Persian common and dialog translations, accepts fa as a main locale, and tests Persian menu and dialog messages.
Update language lists and documentation electron-builder.json5, README.md, AGENTS.md
Adds Persian to Electron and Microsoft Store language lists and the README supported-language list. Updates the documented locale count from 16 to 18.
This adds Persian as a selectable language across the app and its installers, with tests for the native menu and dialog strings. No actionable merge-blocking risk was found; Persian wording and right-to-left layout are best confirmed by a native-speaker check.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "feat(i18n): add Persian (fa) locale" names the main change: adding the Persian (fa) locale. The raw summary shows registration in config, i18n.ts, electron-builder, and new fa locale JSON f…
Description check
The description follows the template's main sections. It has a Summary, a Type of change (Feature checked), Release impact (Minor checked), Desktop impact (Installer / packaging and Not platform-speci…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(i18n): add Persian (fa) locale" names the main change: adding the Persian (fa) locale. The raw summary shows registration in config, i18n.ts, electron-builder, and new fa locale JSON files, which all match the title.
Full details: Description check
Explanation
The description follows the template's main sections. It has a Summary, a Type of change (Feature checked), Release impact (Minor checked), Desktop impact (Installer / packaging and Not platform-specific checked), and Testing with commands and results. The Related issue section is missing: it still reads 'Fixes #' with no issue number. The Screenshots / video section is also absent, though the change is a UI locale addition and the author did not add screenshots. The description is mostly complete.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
fa(فارسی) to the desktop app. This covers all 1,223 strings in the seven existing namespaces, including the recording bar, editor, timeline, keyboard shortcuts, and native dialogs.The Persian copy was prepared with AI assistance. Feedback from Persian-speaking reviewers is welcome.
Type of change
Release impact
Desktop impact
Testing
npm run i18n:checkand Biome on the changed filesnpm run teston macOS (5,792 passed, 8 skipped)fa-IRlanguage suggestion, switching between Persian and English, persistence after reload, the recording bar, editor, keyboard shortcuts, and source picker.Summary by CodeRabbit