You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(i18n): add Vazirmatn for Persian and Arabic - #1643
Bundle the official Vazirmatn 33.003 assets and the SIL OFL notice. The Persian (fa) and Arabic (ar) interfaces use the local variable font for Arabic-script text. Latin UI glyphs use Geist.
Add Vazirmatn to the existing caption font picker and ship its regular and bold faces for native rendering.
Cover Persian and Arabic glyphs in both weights and the saved caption font choice.
Related work
The Persian locale is proposed in #1642. This branch targets main independently. The Arabic interface and caption font picker can be exercised from this branch.
Type of change
Feature
Release impact
Minor
Desktop impact
Installer / packaging
Not platform-specific
Testing
npm run i18n:check, app and test type checks, and npm run build-vite.
npm run test on macOS (5,785 passed, 8 skipped).
Checked the production UI in Chromium with external requests blocked. Verified the actual glyph fonts after switching English → Arabic → Persian → English. The Persian smoke build included the locale files from feat(i18n): add Persian (fa) locale #1642.
Rendered Persian bold and Arabic regular with the native macOS compositor and verified a 30-frame MP4 export.
Summary by CodeRabbit
New Features
Added Vazirmatn as a font option for captions and annotations.
Persian and Arabic interface text now uses Vazirmatn UI, while retaining Geist as a fallback.
No actionable comments were generated in the recent review.
Walkthrough
The change adds Vazirmatn to the text font families and configures it for Persian and Arabic UI text. It also adds font selection and glyph metric test coverage, plus Vazirmatn’s license and attribution.
The text font family list and Persian and Arabic UI font rules include Vazirmatn. Tests cover font selection and glyph metrics. The font license and upstream attribution are added to the repository.
This change adds a local Vazirmatn font for Persian and Arabic text and offers it in the caption font picker. No actionable merge-blocking issue was found, so it looks safe to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "feat(i18n): add Vazirmatn for Persian and Arabic" states the main change: bundling the Vazirmatn font to support Persian and Arabic interfaces. The changeset adds the font files, license no…
Description check
The description follows the template's main sections: Summary, Related work, Type of change, Release impact, Desktop impact, and Testing. It describes the Vazirmatn bundling, the caption font picker c…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(i18n): add Vazirmatn for Persian and Arabic" states the main change: bundling the Vazirmatn font to support Persian and Arabic interfaces. The changeset adds the font files, license notice, font-face and token CSS, the TEXT_FONT_FAMILIES entry, and tests covering Persian and Arabic glyphs, all of which match the title.
Full details: Description check
Explanation
The description follows the template's main sections: Summary, Related work, Type of change, Release impact, Desktop impact, and Testing. It describes the Vazirmatn bundling, the caption font picker change, the Persian and Arabic glyph coverage, and the test commands run. The template's Related issue section ("Fixes #") is missing. The Screenshots / video section is also missing, although the change is visual and the template asks for screenshots or a video for UI changes. The author replaced the Related issue section with a Related work section that references #1642 but does not link an issue.
Resolution
Consider adding the Related issue line (for example, "Fixes #" or "Refs #") and a Screenshots / video section for the Arabic and Persian UI and caption font picker changes. These are non-critical omissions, so the check still passes.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.1)
Clippy execution failed
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fa) and Arabic (ar) interfaces use the local variable font for Arabic-script text. Latin UI glyphs use Geist.Related work
The Persian locale is proposed in #1642. This branch targets
mainindependently. The Arabic interface and caption font picker can be exercised from this branch.Type of change
Release impact
Desktop impact
Testing
npm run i18n:check, app and test type checks, andnpm run build-vite.npm run teston macOS (5,785 passed, 8 skipped).Summary by CodeRabbit