Skip to content

Expand Extensions detail descriptions to full width #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brsbl wants to merge 1 commit into from
+18 −8
Closed

Expand Extensions detail descriptions to full width #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/app/src/components/tools/PluginDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export function CatalogPluginDetail({
>
<ResourceDetailStack>
<ResourceDetailOverviewSection label="About">
<p className="max-w-prose text-sm leading-relaxed text-muted-foreground">
<p className="max-w-none text-sm leading-relaxed text-muted-foreground">
{entry.description.length > 0
? entry.description
: "This plugin does not describe itself."}
Expand Down Expand Up @@ -388,7 +388,7 @@ export function PluginDetail({
>
<ResourceDetailStack>
<ResourceDetailOverviewSection label="About">
<p className="max-w-prose text-sm leading-relaxed text-muted-foreground">
<p className="max-w-none text-sm leading-relaxed text-muted-foreground">
{plugin.description ?? "This plugin does not describe itself."}
</p>
</ResourceDetailOverviewSection>
Expand Down
11 changes: 8 additions & 3 deletions apps/app/src/components/tools/detail-page-recipes.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,14 @@ describe("Plugin detail recipe", () => {
expect(renderedRecipe(container).map(([kind]) => kind)).toContain(
"overview",
);
expect(
screen.getByText("This plugin does not describe itself."),
).toBeTruthy();
const description = screen.getByText(
"This plugin does not describe itself.",
);
expect(description.className).not.toContain("max-w-prose");
expect(description.className).toContain("max-w-none");
expect(description.className).toContain("text-sm");
expect(description.className).toContain("leading-relaxed");
expect(description.className).toContain("text-muted-foreground");
});

it("lists declared capabilities without category chrome", () => {
Expand Down
11 changes: 8 additions & 3 deletions apps/app/src/views/ToolsView.plugin-detail.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,14 @@ describe("PluginDetail official catalog lifecycle", () => {
expect(screen.getByRole("heading", { name: "GitHub" })).toBeTruthy();
expect(screen.getByText("BB Official")).toBeTruthy();
expect(screen.getByText("Developer tools")).toBeTruthy();
expect(
screen.getByText("Browse GitHub issues and pull requests in BB."),
).toBeTruthy();
const description = screen.getByText(
"Browse GitHub issues and pull requests in BB.",
);
expect(description.className).not.toContain("max-w-prose");
expect(description.className).toContain("max-w-none");
expect(description.className).toContain("text-sm");
expect(description.className).toContain("leading-relaxed");
expect(description.className).toContain("text-muted-foreground");
expect(screen.queryByText("Capabilities")).toBeNull();
expect(container.querySelector('[data-icon="Github"]')).not.toBeNull();

Expand Down
Loading