Skip to content

Expand Extensions detail descriptions to full width - #1116

Closed
brsbl wants to merge 1 commit into
bb/make-browse-first-extensions-tab-thr_7db2ut5247from
bb/full-width-detail-descriptions-thr_7db2ut5247
Closed

Expand Extensions detail descriptions to full width#1116
brsbl wants to merge 1 commit into
bb/make-browse-first-extensions-tab-thr_7db2ut5247from
bb/full-width-detail-descriptions-thr_7db2ut5247

Conversation

@brsbl

@brsbl brsbl commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the prose-width cap from installed and catalog plugin descriptions
  • preserve the existing typography and spacing classes
  • add regression assertions for both detail variants

Verification

  • pnpm exec vitest run apps/app/src/views/ToolsView.plugin-detail.test.tsx apps/app/src/components/tools/detail-page-recipes.test.tsx (70 passed)
  • pnpm exec turbo run typecheck --filter=@bb/app
  • pnpm exec turbo run lint --filter=@bb/app (0 errors; existing warnings only)
  • real-app visual QA at 1440×900 and 520×800 on installed and catalog plugin detail pages

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

I am the SlopCop. I am reviewing this pull request under the review rule.

The stack contains only #1116. A second scan after two minutes found no later pull request. I skipped no pull requests.

I started parallel security, code-quality, architecture, and performance reviews. I will test the top pull request through the app when the local route permits it.

@brsbl brsbl closed this Aug 7, 2026

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

Security review complete. I found no security issues.

The change only replaces static width classes. React still escapes both description values as text. The diff adds no trust boundary, authorization, dependency, or data-exposure change. git diff --check passed.

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

Performance review complete. I found no performance issues.

The parent page limits content to max-w-5xl. The new class adds no render work, dependency, or meaningful bundle size. The changed tests passed through Turbo: 70 tests passed.

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

Code-quality and architecture review complete. I found no actionable issues.

The shared resource layout already owns the page and section structure. The catalog and installed plugin descriptions use two parallel render paths. Their small class and fallback duplication does not justify another abstraction. Both changed test files passed, and GitHub reports all required checks as successful.

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

End-to-end review complete on the top pull request. I found no visual or route issue.

I started the source app and enabled the Extensions experiment. I opened the GitHub catalog detail and the installed Remote access detail. In both paths, the description measured 984 pixels, equal to the About section width. The computed maximum width was none. I also inspected the GitHub detail screenshot.

@SawyerHood SawyerHood left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 SLOP COP 🚨 · review

Final review complete. I found no issues.

The stack contains only #1116, and I skipped no pull requests. The security, code-quality, architecture, and performance reviews found no actionable problem. The focused Turbo run passed 70 tests. The browser test covered both catalog and installed plugin detail routes. Both descriptions filled their 984-pixel About sections. All GitHub checks passed. The final GPT-5.6 gate found no issue.

I used a comment-only review. I did not use GitHub's approval or change-request action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants