Repository navigation
Conversation
pie575
force-pushed
the
codex/kb-comparison-followup-653
branch
from
October 19, 2026 20:10
bea99ce to
fcea64d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This follow-up contains the remaining integration and comparison changes across eight KB articles. The original eleven issue-specific commits remain linked below for history; subsequent editorial corrections and fixes now included in #653 are reflected in the current diff.
Stack: #648 → #653 → this PR. The base is #653’s branch,
kb/gt-vs-leaderboard-tools-fixes, now at4193e2c5. The original review commits remain in history; some fixes are now included in the parent. Review the current diff for the remaining follow-up changes. No new article slugs.Editorial correction: The Python SDK defect discussion has been removed from #653 and this branch. Its proposed fixes are tracked in generaltranslation/gt-python#36 and generaltranslation/gt-python#37. The obsolete cache-description commit is dropped; the review index below reflects the rebased branch.
Review each change:
Validation: The earlier integration pass passed all content validators, 201 validator tests, a 595-page build, browser checks, and the rendering/integration checks documented in the review record. For the latest audit, KB, internal-link, reference-link, unsafe-HTML, callout, and structure checks pass. Four extracted catalog configurations pass
gt2.26.5 dry runs; these check source discovery, not hosted generation.Evidence limits: The live GT API rejected the validation request with HTTP 401; no test project was created. Polish rendering uses supplied translations, and the JSX branch-expansion test mocks the AI boundary. Hosted generation quality and preservation of reviewed edits across a subsequent generation run remain unverified. Mobility checks use SQLite sequential edits, not PostgreSQL concurrency; Symfony migration commands were checked against documentation rather than run in a full Symfony app. These limits are not claims of end-to-end publication readiness.
KB editorial audit — October 19: Inherited the five-article defect audit from #653 and removed the remaining failure narratives in the follow-up. The i18n-tasks example now calls the Rails adapter actually provided in this branch. The original eleven review commits remain in history; this audit supersedes their defect-related wording. KB, internal-link, reference-link, and unsafe-HTML validation pass. Engineering defect evidence stays outside published KB prose; the NestJS scanner reproduction is tracked in generaltranslation/gt#2474. This audit does not merge or publish the articles.
Positioning review — October 19: Carried the revised #653 copy into this branch: clearer GT benefits, a scoped competitor benchmark, and factual corrections without internal rebuttals. The separately proposed integration arguments remain here. All content validators pass; fenced code examples are unchanged from the previous head. Some original commit links now describe changes already included in #653.
Weblate review — October 19: Restored the GT recommendation in the summary, benefits, and conclusion. Moved the same-gettext comparison into the coexistence section and removed the fallback illustration and repeated defensive qualifications. The POT configuration is unchanged. All content validators pass; the production build passed before the final quickstart-link correction, which passed the link and MDX checks. No new hosted translation run was performed.