Skip to content

fix(resolve): map grok-build to grok in the pid walk #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fujibee merged 2 commits into from
Aug 18, 2026
Merged

fix(resolve): map grok-build to grok in the pid walk #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2717a9
fix(resolve): map grok-build to grok in the pid walk (#859)
apstndb Aug 17, 2026
761f087
docs(resolve): note why pid names omit the shared basename agent (#856)
apstndb Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/lib/resolve-project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,9 @@ agmsg_find_registered_project_variant() {
}

# Map an agent type to the binary basename(s) its process may carry.
# Names must be type-distinctive. Do not list `agent`: Homebrew grok-build
# and the Cursor CLI installer both use that basename (#856). Matching it
# would attach the wrong pid (#93). The alias is an intentional miss.
_agmsg_agent_binaries() {
case "$1" in
claude-code) echo "claude" ;;
Expand All @@ -236,6 +239,7 @@ _agmsg_agent_binaries() {
antigravity) echo "antigravity" ;;
copilot) echo "copilot" ;;
opencode) echo "opencode" ;;
grok-build) echo "grok" ;;
*) echo "claude codex gemini" ;;
esac
}
Expand Down
5 changes: 5 additions & 0 deletions tests/test_resolve_project.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,3 +435,8 @@ setup_git_repo() {
[ "$result" = "$base/parent" ]
rm -rf "$base"
}

@test "agent-binaries: grok-build maps to grok (#859)" {
[ "$(_agmsg_agent_binaries grok-build)" = "grok" ]
[ "$(_agmsg_agent_binaries claude-code)" = "claude" ]
}
Loading