fix(resolve): map grok-build to grok in the pid walk - #860
Conversation
Without this arm, grok-build falls through to claude/codex/gemini, so agmsg_agent_pid never sees a live grok and watchers are not liveness-gated. Co-authored-by: Cursor <cursoragent@cursor.com>
…ibee#856) Homebrew grok-build and the Cursor CLI installer both ship `agent`. Listing it on either type would attach the wrong pid (fujibee#93). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for this, and sorry it sat. This was red for a reason that had nothing to do with your change. One macOS Every ubuntu shard, every Windows leg and the other three macOS shards were The cap is being hit because a handful of tests are slow: eight cases account for Nothing is needed from you. Review to follow. |
Fixes #859.
_agmsg_agent_binarieshas nogrok-buildarm, so the type falls through toclaude codex geminiand grok-build watchers are not liveness-gated.Independently mergeable. Split out of #856 because cursor monitor only needs the
cursor-agentarm. Readingdetect_procfrom the manifest stays #631.Do not list
agent(Homebrew grok-build and the Cursor CLI installer share that basename). The policy is on #856; this PR comments the omission.#858 stays a draft until this and #857 have landed.
Test plan
bats tests/test_resolve_project.bats --filter agent-binariesbats tests/test_resolve_project.bats