Allow standard response from EST server#77
Merged
vkhoroz merged 1 commit intofoundriesio:mainfrom Feb 13, 2026
Merged
Conversation
vkhoroz
reviewed
Feb 12, 2026
vkhoroz
reviewed
Feb 12, 2026
vkhoroz
reviewed
Feb 12, 2026
Member
vkhoroz
left a comment
vkhoroz
left a comment
There was a problem hiding this comment.
Functionally, the change itself LGTM to me.
Only needs some cleanups.
until now est protocal was diverged from standard due to different http code and rejected contenttype with smime param: weaken check to allow both 200 and 201 code and ignore smime param at content-type header. User-Agent incremented to differenciate this from server side. Signed-off-by: Seo Suchan <tjtncks@gmail.com>
vkhoroz
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
until now we used wrong implementaion of est protocal due to wrong http code/contenttype:. weaken check to allow both old slang and standard reply. User-Agent incremented to differenciate this.